Skip to content

M2351: Update BSP and bugfix #12404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 11, 2020
Merged

M2351: Update BSP and bugfix #12404

merged 5 commits into from
Feb 11, 2020

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Feb 11, 2020

Summary of changes

This PR updates BSP and includes bugfix on M2351:

  1. Align with SPI module naming
  2. Add missing H port for GPIO IRQ
  3. Fix GPIO rising/falling edge interrupts cannot exist simultaneously (mbed_hal_fpga_ci_test_shield-gpio_irq)
  4. Other code alignment with BSP
  5. Update non-PSA/PSA secure image/library with this BSP update

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

ccli8 added 5 commits February 10, 2020 09:07
@ccli8
M2351: Refine PeripheralNames.h
82770d7 
No logic change and bugfix
@ccli8
M2351: Update BSP and bugfix
a2c9ae6 
Align with mainline BSP and fix relevant bugs:

1.  Align with SPI module naming
    (1) Remove SPI5
    (2) Degrade QSPI0 to SPI4 so that it can use for standard SPI
2.  Fix some code lacking GPIO H
3.  Implement __PC(...) by following BSP instead of with MBED_CALLER_ADDR()
4.  Add SCU_IRQHandler(). Change printf(...) with interrupt-safe error(...)
5.  Other minor alignment change
@ccli8
M2351: Fix GPIO rising/falling edge interrupts cannot exist simultane…
6f793fb 
…ously
@ccli8
M2351: Update non-PSA secure image/lib with BSP update
ee8236b
@ccli8
M2351: Update PSA secure image/lib with BSP update
3d9c7b2
@ccli8 ccli8 force-pushed the nuvoton_m2351_bsp branch from 7cdd06c to 3d9c7b2 Compare February 11, 2020 02:13
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@Ronny-Liu @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from Ronny-Liu and a team February 11, 2020 04:00
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 11, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Feb 11, 2020
@mbed-ci
Copy link

mbed-ci commented Feb 11, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Feb 11, 2020
@0xc0170 0xc0170 merged commit 8e52205 into ARMmbed:master Feb 11, 2020
@mergify mergify bot removed the ready for merge label Feb 11, 2020
@cyliangtw cyliangtw deleted the nuvoton_m2351_bsp branch March 9, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@Ronny-Liu Ronny-Liu Awaiting requested review from Ronny-Liu

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccli8 @ciarmcom @0xc0170 @mbed-ci