Skip to content

Fix static ram memory statistics for arm compiler #12462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

maciejbocianski
Copy link
Contributor

Summary of changes

Don't count ARM_LIB_HEAP in static RAM pool

stats for mbed-os-example-blinky
without fix

| Module              |     .text |   .data |       .bss |
|---------------------|-----------|---------|------------|
| [lib]\c_w.l         | 10571(+0) |  16(+0) |    348(+0) |
| [lib]\fz_wm.l       |    34(+0) |   0(+0) |      0(+0) |
| [lib]\libcppabi_w.l |    44(+0) |   0(+0) |      0(+0) |
| [lib]\m_wm.l        |    48(+0) |   0(+0) |      0(+0) |
| anon$$obj.o         |    32(+0) |   0(+0) | 197888(+0) |
| main.o              |    60(+0) |   0(+0) |      0(+0) |
| mbed-os\drivers     |   388(+0) |   0(+0) |      0(+0) |
| mbed-os\features    |    70(+0) |   0(+0) |      0(+0) |
| mbed-os\hal         |  1252(+0) |   8(+0) |    131(+0) |
| mbed-os\platform    |  4577(+0) |  64(+0) |    324(+0) |
| mbed-os\rtos        |  7768(+0) | 168(+0) |   6625(+0) |
| mbed-os\targets     | 10360(+0) |  36(+0) |    341(+0) |
| Subtotals           | 35204(+0) | 292(+0) | 205657(+0) |
Total Static RAM memory (data + bss): 205949(+0) bytes
Total Flash memory (text + data): 35496(+0) bytes

and with fix

| Module              |     .text |   .data |      .bss |
|---------------------|-----------|---------|-----------|
| [lib]\c_w.l         | 10571(+0) |  16(+0) |   348(+0) |
| [lib]\fz_wm.l       |    34(+0) |   0(+0) |     0(+0) |
| [lib]\libcppabi_w.l |    44(+0) |   0(+0) |     0(+0) |
| [lib]\m_wm.l        |    48(+0) |   0(+0) |     0(+0) |
| anon$$obj.o         |    32(+0) |   0(+0) |  2304(+0) |
| main.o              |    60(+0) |   0(+0) |     0(+0) |
| mbed-os\drivers     |   388(+0) |   0(+0) |     0(+0) |
| mbed-os\features    |    70(+0) |   0(+0) |     0(+0) |
| mbed-os\hal         |  1252(+0) |   8(+0) |   131(+0) |
| mbed-os\platform    |  4577(+0) |  64(+0) |   324(+0) |
| mbed-os\rtos        |  7768(+0) | 168(+0) |  6625(+0) |
| mbed-os\targets     | 10360(+0) |  36(+0) |   341(+0) |
| Subtotals           | 35204(+0) | 292(+0) | 10073(+0) |
Total Static RAM memory (data + bss): 10365(+0) bytes
Total Flash memory (text + data): 35496(+0) bytes

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@bridadan @evedon @jamesbeyond


don't count ARM_LIB_HEAP in static RAM pool
@ciarmcom
Copy link
Member

@maciejbocianski, thank you for your changes.
@jamesbeyond @evedon @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@JanneKiiskila JanneKiiskila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixing @maciejbocianski

@mergify mergify bot added needs: CI and removed needs: review labels Feb 19, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 19, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 19, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 589a9a4 into ARMmbed:master Feb 19, 2020
@mergify mergify bot removed the ready for merge label Feb 19, 2020
@JanneKiiskila
Copy link
Contributor

@adbridge @0xc0170 @andypowers - it would make sense to merge his also to 5.15. branch, because memory numbers are always important in embedded system.

0xc0170 added a commit that referenced this pull request May 8, 2020
Backport Arm C static RAM fix to Mbed OS 5.15 (#12462) (Mbed OS 5.15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants