Add WPA3 support in mbed-os for green tea tests #12472

praveenCY · 2020-02-19T19:45:28Z

Summary of changes

Add WPA3, WPA3_WPA2 Security type support in mbed-os
Add WPA3, WPA3_WPA2 Security changes in green tea tests
Add WPA3_WPA2 Security changes for Cypress Kits

WPA3_WPA2 Mode in STA enables to connect to WPA2 AP or WPA3 AP with same SSID and password.
Also added option to support different password WPA2_PSK for above case using below configuration in mbed_app.json

    "wifi-password-wpa2psk": {
        "help": "WiFi WPA2 PSK Password for WPA3_WPA2 Mode",
        "value": "\"test12345678\""
    }

Green tea tests does not have target based filtering added till now and this security mode will fail for targets which does not support WPA3. So user needs to check target specfications before updating mbed_app.json to WPA3 security mode.

NOTE: One more way to support is to add target specific WPA3 support "WIFI_WPA3_SUPPORT" in targets.json and new green tea test in wifi just for WPA3
master...praveenCY:pr/wpa3_new_greentea_test

Impact of changes

Migration actions required

Documentation

Refer to "get_security : NSAPI_SECURITY_WPA3" print in the below logs which confirms the security type used for this test

greentea_CY8CKIT_062S2_43012_WPA3.txt

greentea_CY8CKIT_062_WIFI_BT_WPA3.txt

Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[*] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[*] Covered by existing mbed-os tests (Greentea or Unittest)
[*] Tests / results supplied as part of this PR

Reviewers

@balajicyp @satya1957 @ifyall

ciarmcom · 2020-02-19T20:00:36Z

@praveenCY, thank you for your changes.
@satya1957 @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

0xc0170

one typo request, otherwise looks fine to me

0xc0170 · 2020-02-25T16:00:58Z

TESTS/network/wifi/README.md

@@ -37,6 +37,7 @@ The general test environment consists of DUTs, base stations, a network connecti
    -   Time protocol, [RFC 868](https://tools.ietf.org/html/rfc868) in both TCP and UDP. Port 37.
 -   Channels to be used must be different for both APs. For secure on channel number is later referred as `<ch:secure>` and for unsecure on `<ch:unsecure>`.
 -   MAC addresses of Wi-Fi APs must be known. These are later referred to as `<mac:secure>` and `<mac:unsecure>`.
+-   WPA3 maynot be supported for all target platforms, Refer to target specifications before updating security protocol to WPA3 or WPA3/WPA2 in  `mbed_app.json`


done.
Please review

Pull request has been modified.

0xc0170 · 2020-02-26T15:46:56Z

CI started

@ARMmbed/mbed-os-ipcore Please review

mbed-ci · 2020-02-26T17:17:42Z

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_cloud-client-pytest

ifyall · 2020-02-26T18:11:44Z

@0xc0170,

I can't access the failing logs from the cloud test. Can you provide them to @praveenCY and I?

Thank you in advance,

Ian

VeijoPesonen · 2020-02-27T12:27:18Z

TESTS/network/wifi/README.md

@@ -58,6 +59,8 @@ Please refer to the following table for priorities of test cases. Priorities are
 |     |                                         | NSAPI_SECURITY_WPA         | SHOULD   |
 |     |                                         | NSAPI_SECURITY_WPA2        | SHOULD   |
 |     |                                         | NSAPI_SECURITY_WPA_WPA2    | MUST     |
+|     |                                         | NSAPI_SECURITY_WPA3_WPA2   | SHOULD   |


I would prefer NSAPI_SECURITY_WPA2_WPA3 for consistency. But this is just my opinion and can be ignored if no one else feels the same.

0xc0170 · 2020-03-02T09:54:03Z

@ifyall There's been a known issue with client tests, I restarted it

adbridge · 2020-03-25T15:35:54Z

CI started

mbed-ci · 2020-03-26T02:11:28Z

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

0xc0170 · 2020-03-26T17:27:04Z

TEst restarted

adbridge · 2020-03-27T12:26:17Z

Device has been power cycled let's see if that fixes the issue

adbridge · 2020-03-27T12:27:06Z

CI started

mbed-ci · 2020-03-27T14:14:38Z

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

adbridge · 2020-03-27T14:24:51Z

More CI issues, retrying

mbed-ci · 2020-03-27T19:12:25Z

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

0xc0170 · 2020-03-30T07:40:13Z

test restarted

mergify bot added the needs: work label Feb 19, 2020

ciarmcom requested review from satya1957 and a team February 19, 2020 20:00

ciarmcom added the needs: review label Feb 19, 2020

praveenCY force-pushed the pr/wpa3_support_merge branch from 6286ca9 to 8d534da Compare February 19, 2020 22:42

0xc0170 added needs: review devices: cypress and removed needs: review needs: work labels Feb 20, 2020

0xc0170 previously requested changes Feb 25, 2020

View reviewed changes

mergify bot added needs: work and removed needs: review labels Feb 25, 2020

Add WPA3 support for green tea tests

8b97e4c

praveenCY force-pushed the pr/wpa3_support_merge branch from 8d534da to 8b97e4c Compare February 25, 2020 18:15

0xc0170 approved these changes Feb 26, 2020

View reviewed changes

0xc0170 removed the request for review from a team February 26, 2020 15:46

mergify bot added needs: CI and removed needs: work labels Feb 26, 2020

mergify bot added needs: work and removed needs: CI labels Feb 26, 2020

VeijoPesonen reviewed Feb 27, 2020

View reviewed changes

0xc0170 removed the needs: work label Mar 2, 2020

satya1957 approved these changes Mar 21, 2020

View reviewed changes

adbridge added needs: CI and removed needs: review labels Mar 25, 2020

mergify bot added ready for merge and removed needs: CI labels Mar 25, 2020

adbridge added needs: CI and removed ready for merge labels Mar 25, 2020

mergify bot added needs: work and removed needs: CI labels Mar 26, 2020

0xc0170 added needs: CI and removed needs: work labels Mar 26, 2020

adbridge mentioned this pull request Mar 27, 2020

Refactor TDB internal bounds computation #11629

Merged

mergify bot added needs: work and removed needs: CI labels Mar 27, 2020

mergify bot added needs: CI and removed needs: work labels Mar 27, 2020

mergify bot added ready for merge and removed needs: CI labels Mar 30, 2020

0xc0170 added the release-version: 6.0.0-beta-1 label Mar 31, 2020

0xc0170 merged commit fea7c1a into ARMmbed:master Mar 31, 2020

mergify bot removed the ready for merge label Mar 31, 2020

Add WPA3 support in mbed-os for green tea tests #12472

Add WPA3 support in mbed-os for green tea tests #12472

Uh oh!

Conversation

praveenCY commented Feb 19, 2020

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

ciarmcom commented Feb 19, 2020

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Feb 26, 2020

Uh oh!

mbed-ci commented Feb 26, 2020

Uh oh!

ifyall commented Feb 26, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Mar 2, 2020

Uh oh!

adbridge commented Mar 25, 2020

Uh oh!

mbed-ci commented Mar 26, 2020

Uh oh!

0xc0170 commented Mar 26, 2020

Uh oh!

adbridge commented Mar 27, 2020

Uh oh!

adbridge commented Mar 27, 2020

Uh oh!

mbed-ci commented Mar 27, 2020

Uh oh!

adbridge commented Mar 27, 2020

Uh oh!

mbed-ci commented Mar 27, 2020

Uh oh!

0xc0170 commented Mar 30, 2020

Uh oh!

Uh oh!