Skip to content

M2351: Fix some minor issues #12478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 24, 2020
Merged

M2351: Fix some minor issues #12478

merged 3 commits into from
Feb 24, 2020

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Feb 20, 2020

Summary of changes

This PR tries to fix the following issues on M2351. Secure image/lib is not influenced by this change, so no need to rebuild it.

  1. Fix NSC_Init(...).
  2. Fix interrupt vector with BSP update.
  3. Fix RTC comment

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

ccli8 added 3 commits February 19, 2020 17:51
@ccli8
M2351: Fix RTC comment
d5620b6
@ccli8
M2351: Fix interrupt vector with BSP update
7328467
@ccli8
M2351: Fix NSC_Init(...)
34d3d43 
Actually, NSC_Init(...) is not used by secure code currently. No need to rebuild secoure image/lib.
@ciarmcom ciarmcom requested review from Ronny-Liu and a team February 20, 2020 12:00
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@Ronny-Liu @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 21, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Feb 21, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 24, 2020

CI restarted (internal error)

@mbed-ci
Copy link

mbed-ci commented Feb 24, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 119931e into ARMmbed:master Feb 24, 2020
@mergify mergify bot removed the ready for merge label Feb 24, 2020
@ccli8 ccli8 deleted the nuvoton_m2351_minor branch February 25, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@Ronny-Liu Ronny-Liu Awaiting requested review from Ronny-Liu

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccli8 @ciarmcom @0xc0170 @mbed-ci