Skip to content

NUCLEO_G474RE: Add new platform #12482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Jun 8, 2020
Merged

NUCLEO_G474RE: Add new platform #12482

merged 32 commits into from
Jun 8, 2020

Conversation

AGlass0fMilk
Copy link
Member

Summary of changes

Added initial support for NUCLEO_G474RE target

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

See attached test results for GCC ARM toolchain.

GCC ARM Version Info:

arm-none-eabi-gcc (GNU Tools for Arm Embedded Processors 9-2019-q4-major) 9.2.1 20191025 (release) [ARM/arm-9-branch revision 277599]
Copyright (C) 2019 Free Software Foundation, Inc.

nucleo-g474re-test.log

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant
@ARMmbed/team-st-mcd

@AGlass0fMilk AGlass0fMilk mentioned this pull request Feb 20, 2020
Closed
@ciarmcom ciarmcom requested a review from a team February 20, 2020 20:00
@ciarmcom
Copy link
Member

@AGlass0fMilk, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Feb 28, 2020
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 28, 2020

@ARMmbed/team-st-mcd Please review

@mergify mergify bot added needs: CI and removed needs: review labels Feb 28, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 28, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 28, 2020

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM

@mergify mergify bot added needs: work and removed needs: CI labels Feb 28, 2020
@jeromecoutant
Copy link
Collaborator

jeromecoutant commented Mar 9, 2020 •
edited
Loading

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM

Seems that
targets/TARGET_STM/TARGET_STM32G4/spi_api.c is missing

or remove SPI feature in a first step in targets.json ?

jeromecoutant
jeromecoutant suggested changes Mar 9, 2020
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review done.
First quick tests done : ARM echo test OK! :-)

About license header, maybe you could check STM32G0 files.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 24, 2020

@AGlass0fMilk I'll close this PR as it has not been updated for more than 2 weeks, please reopen with an update to progress this one.

@0xc0170 0xc0170 closed this Mar 24, 2020
@AGlass0fMilk
Copy link
Member Author

@0xc0170

I have updated my branch with the changes requested and rebased. Can you reopen this PR?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2020

I can't neither, github does not allow (states it was recreated or forced push - the latter could be here but why we can't reopen) :(

@AGlass0fMilk
Copy link
Member Author

Ah, I did force push during the rebase. I'll just open a new PR.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2020

you can also reopen, just rebase to revert the latest rebase, let it be as it was at closure . Reopen and then force push (see https://gist.github.com/robertpainsi/2c42c15f1ce6dab03a0675348edd4e2c)

@AGlass0fMilk
Copy link
Member Author

I can't reopen it after force pushing the old PR head. @0xc0170 is it possible for you to reopen it now? Maybe I don't have permissions.

@AGlass0fMilk AGlass0fMilk mentioned this pull request Apr 3, 2020
Merged
@AGlass0fMilk
Copy link
Member Author

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM

Seems that
targets/TARGET_STM/TARGET_STM32G4/spi_api.c is missing

or remove SPI feature in a first step in targets.json ?

Still need to address this.

First review done.
First quick tests done : ARM echo test OK! :-)

About license header, maybe you could check STM32G0 files.
@jeromecoutant not sure what you meant about licenses. Are any of them incorrect?

@AGlass0fMilk
Copy link
Member Author

Let it be noted:

Still to be added: CAN, USBDEVICE, QSPI, CRC(?), TRNG

@AGlass0fMilk
Copy link
Member Author

@0xc0170 can you reopen this PR? I will then rebase again and push up my changes.

@0xc0170 0xc0170 reopened this Apr 7, 2020
@mergify mergify bot dismissed 0xc0170’s stale review May 20, 2020 10:41

Pull request has been modified.

@mergify mergify bot added the needs: work label May 20, 2020
@AGlass0fMilk
Copy link
Member Author

@0xc0170 This should be ready for integration (pending travis tests).

I ran mbed test -v with a NUCLEO_G474RE and have attached the test log to this comment. All tests passed.
g474-test-5-20-20.log

jeromecoutant
jeromecoutant approved these changes May 22, 2020
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests OK also on my side for GCC, ARM and IAR

@AGlass0fMilk
Copy link
Member Author

@0xc0170 LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 4, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 4, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@AGlass0fMilk
Copy link
Member Author

Woohoo, let's merge!

@0xc0170 0xc0170 added release-type: patch Indentifies a PR as containing just a patch and removed needs: CI labels Jun 8, 2020
@0xc0170 0xc0170 merged commit 8d26d77 into ARMmbed:master Jun 8, 2020
@mergify
Copy link

mergify bot commented Jun 8, 2020

This PR does not contain release version label after merging.

@mergify mergify bot added the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Jun 8, 2020
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
@0xc0170 0xc0170 removed the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Jun 22, 2021
@CRA-CNRS CRA-CNRS mentioned this pull request Nov 5, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Assignees
No one assigned
Labels
release-version: 6.1.0 scope: new-target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AGlass0fMilk @ciarmcom @0xc0170 @mbed-ci @jeromecoutant @adbridge