Skip to content

mergify: add "mergify skip" label #12514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2020
Merged

mergify: add "mergify skip" label #12514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .mergify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ pull_request_rules:
conditions:
# Travis failing
- status-failure~=continuous-integration/travis-ci/pr
- "label!=mergify skip"
actions:
label:
add: ['needs: work']
Expand All @@ -49,6 +50,7 @@ pull_request_rules:
conditions:
# Jenkins CI failing
- status-failure~=continuous-integration/jenkins/pr-head
- "label!=mergify skip"
actions:
label:
add: ['needs: work']
Expand All @@ -59,6 +61,7 @@ pull_request_rules:
conditions:
# Jenkins CI failing - any of the pipeline
- status-failure~=^jenkins-ci
- "label!=mergify skip"
actions:
label:
add: ['needs: work']
Expand Down Expand Up @@ -120,6 +123,7 @@ pull_request_rules:
conditions:
# Labels
- "label!=do not merge"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this will work as separate lines, it says multiple labels should be in a [ ] list....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the list in add/remove labels in actions but for conditions?
How to write these:

      - "label!=do not merge"
      - "label!=mergify skip"
      - "label=needs: CI"

      - "label!=['do not merge', mergify skip]"
      - "label=needs: CI"

I believe both should have the same result if are loaded from yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code snippet was taken from "ready for merge" rule, and that one was working (considering labels), so as it is it should work. Pitty, I can't test here but first merge the config and then on another PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive checked again, also works in case of release label:

-label~=^(release-version)
 -label~=^(Release review required)

So this will work as it is in the PR

- "label!=mergify skip"
- "label=needs: CI"

# Reviewers
Expand Down