Skip to content

[feature-wisun] Disable sleep on STM32F4 as an workaround for stability issues. #12517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

teetak01
Copy link
Contributor

Summary of changes

This workaround is related to Mbed OS issue
#12294

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@artokin @mikter @mikaleppanen @TuomoHautamaki @yogpan01

@ciarmcom
Copy link
Member

@teetak01, thank you for your changes.
@yogpan01 @artokin @mikter @TuomoHautamaki @mikaleppanen @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 26, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Feb 26, 2020
@mbed-ci
Copy link

mbed-ci commented Feb 26, 2020

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Feb 26, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 26, 2020

The results are expected, sleep for that target failed. If this is pushed to a feature branch, every test run needs to be checked if there are any other failures besides sleep.

@teetak01
Copy link
Contributor Author

teetak01 commented Feb 26, 2020

@0xc0170 is there simple way to disable that specific test (and add clear commit-trail) that it is being ignored? I am not very familiar with the greentea side.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 26, 2020

@jamesbeyond What shall we do to exclude this tests for one platform for one branch? Please advise

@artokin
Copy link
Contributor

artokin commented Mar 2, 2020

Agreed with @0xc0170 to push this fix in now. Test will be fixed later.

@artokin artokin merged commit a56a5d3 into ARMmbed:feature-wisun Mar 2, 2020
@jeromecoutant
Copy link
Collaborator

I don't understand the issue,
but maybe you can only remove SLEEP feature in your local mbed_app.json ?

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 2, 2020

That would be better fix 👍

@jamesbeyond
Copy link
Contributor

a proper way to turn off a feature would add "device_has_remove": [ "SLEEP" ] in https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L4292
Or for temporary turn off, would be like Jerome suggested, add the same option in mbed_apps.json

@jeromecoutant
Copy link
Collaborator

I definitively can't approve any change in targets.json file....

@jamesbeyond
Copy link
Contributor

the underlying issue #12294 is currently under investigation, once that been resolved, hope this change would be reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants