Skip to content

tests-integration-net-single: fix build error #12548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2020
Merged

tests-integration-net-single: fix build error #12548

merged 1 commit into from
Mar 3, 2020

Conversation

VeijoPesonen
Copy link
Contributor

Summary of changes

Stops using deprecated TCPSocket constructors and string-based APIs.

Fixes following issues:

[Warning] download_test.cpp@87,15: 'TCPSocket' is deprecated: The TCPSocket(S *stack) constructor is deprecated.It discards the open() call return value.Use another constructor and call open() explicitly, instead. [since mbed-os-5.11] [-Wdeprecated-declarations]
[Error] download_test.cpp@90,45: too many arguments to function call, expected single argument 'address', have 2 arguments

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

mbedgt: test case report:
| target                    | platform_name       | test suite                      | test case                               | passed | failed | result | elapsed_time (sec) |
|---------------------------|---------------------|---------------------------------|-----------------------------------------|--------|--------|--------|--------------------|
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-fs-single     | QSPIF+LFS 1 file, buff     1            | 1      | 0      | OK     | 9.42               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-fs-single     | QSPIF+LFS 1 file, buff     4            | 1      | 0      | OK     | 6.65               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-fs-single     | QSPIF+LFS 1 file, buff    16            | 1      | 0      | OK     | 6.02               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-fs-single     | QSPIF+LFS 1 file, buff    64            | 1      | 0      | OK     | 5.86               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-fs-single     | QSPIF+LFS 1 file, buff   256            | 1      | 0      | OK     | 5.58               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-fs-single     | QSPIF+LFS 1 file, buff  1024            | 1      | 0      | OK     | 5.49               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-fs-single     | QSPIF+LFS 1 file, buff  4096            | 1      | 0      | OK     | 5.17               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-fs-single     | QSPIF+LFS 1 file, buff 16384            | 1      | 0      | OK     | 5.25               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-fs-single     | QSPIF+LFS format                        | 1      | 0      | OK     | 0.2                |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-fs-threaded   | QSPIF+LFS 2 files, buff 4b/256b         | 1      | 0      | OK     | 12.32              |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-fs-threaded   | QSPIF+LFS 3 files, buff 256b/1kb/4kb    | 1      | 0      | OK     | 16.41              |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-fs-threaded   | QSPIF+LFS format                        | 1      | 0      | OK     | 0.23               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-net-single    | WiFi   128 buffer                       | 1      | 0      | OK     | 2.54               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-net-single    | WiFi   256 buffer                       | 1      | 0      | OK     | 1.74               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-net-single    | WiFi  1024 buffer                       | 1      | 0      | OK     | 1.55               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-net-single    | WiFi  4096 buffer                       | 1      | 0      | OK     | 1.54               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-net-single    | WiFi network setup                      | 1      | 0      | OK     | 6.53               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-net-threaded  | WiFi 1 thread                           | 1      | 0      | OK     | 2.15               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-net-threaded  | WiFi 2 threads                          | 1      | 0      | OK     | 5.41               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-net-threaded  | WiFi network setup                      | 1      | 0      | OK     | 5.07               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-stress-net-fs | QSPIF+LFS format                        | 1      | 0      | OK     | 0.22               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-stress-net-fs | QSPIF+LFS+WiFi 1 thread, dl, file seq.  | 1      | 0      | OK     | 2.27               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-stress-net-fs | QSPIF+LFS+WiFi 2 threads, dl, 1kb       | 1      | 0      | OK     | 6.66               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-stress-net-fs | QSPIF+LFS+WiFi 3 threads, dl, 256b, 1kb | 1      | 0      | OK     | 12.22              |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-stress-net-fs | Test memory allocation of 10 K bytes    | 1      | 0      | OK     | 0.07               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-stress-net-fs | Test memory allocation of 20 K bytes    | 1      | 0      | OK     | 0.07               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-stress-net-fs | Test memory allocation of 40 K bytes    | 1      | 0      | OK     | 0.08               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-stress-net-fs | Test memory allocation of 60 K bytes    | 1      | 0      | OK     | 0.07               |
| DISCO_L475VG_IOT01A-ARMC6 | DISCO_L475VG_IOT01A | tests-integration-stress-net-fs | WiFi network setup                      | 1      | 0      | OK     | 3.54               |
mbedgt: test case results: 29 OK

Reviewers

@jamesbeyond
@SeppoTakalo

tests-integration-net-single: fix build error
9dbd5ed 
Stops using deprecated TCPSocket constructors and string-based APIs.
jamesbeyond
jamesbeyond approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added the needs: CI label Mar 2, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 2, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 2, 2020

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit e53b69b into ARMmbed:master Mar 3, 2020
@mergify mergify bot removed the ready for merge label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesbeyond jamesbeyond jamesbeyond approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VeijoPesonen @0xc0170 @mbed-ci @jamesbeyond