Skip to content

STM32 EMAC : increase thread size when mbed-trace is enabled #12567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Discussion started in #12561

Fix #12566

In case of mbed trace enable, stm32_emac_thread size has to be increased, in particular for GCC.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@0xc0170 0xc0170 requested review from artokin and a team March 4, 2020 08:23
@artokin
Copy link
Contributor

artokin commented Mar 4, 2020

Tested on my desk, still get a HardFault:

[ERR ][STE1]: HAL_ETH_Init issue

++ MbedOS Fault Handler ++

FaultType: HardFault

Context:
R0   : 70B002EB
R1   : 00000002
R2   : 00000518
R3   : 0800483F
R4   : 20018778
R5   : FFFFF43C
R6   : 0807189D
R7   : 00000000
R8   : 00000000
R9   : 00000000
R10  : 00000000
R11  : 00000000
R12  : 0806A84D
SP   : 20014E20
LR   : 080691B3
PC   : 08071774
xPSR : 210F0000
PSP  : 20014DB8
MSP  : 2007FFC0
CPUID: 411FC270
HFSR : 40000000
MMFSR: 00000000
BFSR : 00000082
UFSR : 00000000
DFSR : 0000000B
AFSR : 00000000
BFAR : 70B002EB
Mode : Thread
Priv : Privileged
Stack: PSP

-- MbedOS Fault Handler --



++ MbedOS Error Info ++
Error Status: 0x80FF013D Code: 317 Module: 255
Error Message: Fault exception
Location: 0x8071774
Error Value: 0x2005844C
Current Thread: nanostack_event_thread Id: 0x20014E78 Entry: 0x8020135 StackSize: 0x1800 StackMem: 0x20013678 SP: 0x20014E20
For more info, visit: https://mbed.com/s/error?error=0x80FF013D&tgt=DISCO_F769NI
-- MbedOS Error Info --

Copy link
Contributor

@artokin artokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HardFault moved to another location.

@jeromecoutant
Copy link
Collaborator Author

HardFault moved to another location.

So let's integrate this patch ?

@artokin
Copy link
Contributor

artokin commented Mar 4, 2020

@jeromecoutant , the HardFault is still there. It happens slightly later but it must be fixed.

@artokin
Copy link
Contributor

artokin commented Mar 4, 2020

The new HardFault is caused by nanostack-border-router application as it is not able to handle failure in EthernetInterface creation. It will be fixed in PelionIoT/nanostack-border-router#209

The error mentioned in the log above [ERR ][STE1]: HAL_ETH_Init issue is caused by HAL_ETH_Init returning HAL_TIMEOUT. This error causes EthernetInterface creation failure and must be fixed.

@jeromecoutant
Copy link
Collaborator Author

Thx @artokin
So you have to open an new issue for that with your specific setup (as all netsocket tests are working with all ST boards with Ethernet connectors)

@0xc0170
Can we start CI ?

@artokin
Copy link
Contributor

artokin commented Mar 5, 2020

Thanks @jeromecoutant , the new issue is created: #12577

@mergify mergify bot added needs: CI and removed needs: work labels Mar 6, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 6, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Mar 6, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 6, 2020

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 9, 2020

Client restarted, once passed, will merge

@0xc0170 0xc0170 merged commit 0692fc6 into ARMmbed:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HardFault in stm32_emac_thread when traces are enabled
4 participants