Remove Mutex deprecated API

[rajkan01]

Summary of changes

Removed Mutex deprecated API.

Impact of changes

Breaking change: Mutex lock(uint32_t millisec) method have been deprecated since Mbed OS 5.10 and its removed now.

Migration actions required

Use Mutex lock, trylock, trylock_for methods.

Documentation

None

---

Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[x] Major update (Breaking change E.g. Return code change / API behaviour change)

---

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

---

Reviewers

@evedon

---

[ciarmcom]

@rajkan01, thank you for your changes.
@evedon @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

[0xc0170]

CI started

[kjbracey]

As a follow-up, could you also remove the return value from lock, which was planned for deprecation? (And is already RTOS builds only).

[mbed-ci]

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 1
Build artifacts

[evedon]

As a follow-up, could you also remove the return value from lock, which was planned for deprecation? (And is already RTOS builds only).

Let's mark the function with the return value as deprecated for the upcoming release this week and we will remove the deprecated function next month.
cc @rajkan01

[kjbracey]

Let's mark the function with the return value as deprecated

It's been as deprecated as it can be since 5.9 or so (just documentation). You can't actually generate a deprecation warning, as we're not removing the function, just eliminating its return value. :(

There are compiler attributes like [[nodiscard]] to generate warnings if you don't use a return value, but I'm not aware of the opposite - warn if you use it.

[evedon]

Let's mark the function with the return value as deprecated

It's been as deprecated as it can be since 5.9 or so (just documentation). You can't actually generate a deprecation warning, as we're not removing the function, just eliminating its return value. :(

There are compiler attributes like [[nodiscard]] to generate warnings if you don't use a return value, but I'm not aware of the opposite - warn if you use it.

Okay. So let's remove the return value as you suggest in a different PR.

[rajkan01]

Let's mark the function with the return value as deprecated

It's been as deprecated as it can be since 5.9 or so (just documentation). You can't actually generate a deprecation warning, as we're not removing the function, just eliminating its return value. :(
There are compiler attributes like [[nodiscard]] to generate warnings if you don't use a return value, but I'm not aware of the opposite - warn if you use it.

Okay. So let's remove the return value as you suggest in a different PR.

@kjbracey-arm Do we need to remove the return value from unlock?

[kjbracey]

Yes, unlock too. I forgot it was the pair.