Remove Semaphore deprecated APIs #12609

rajkan01 · 2020-03-10T12:22:49Z

Summary of changes

Removed Semaphore deprecated APIs.

Impact of changes

Breaking change: Semaphore wait and wait_until methods have been deprecated since Mbed OS 5.13 and are removed now.

Migration actions required

Use Semaphore acquire, try_acquire, try_acquire_for and try_acquire_until methods.

Documentation

None

Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[x] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon

ciarmcom · 2020-03-10T14:00:44Z

@rajkan01, thank you for your changes.
@evedon @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-test @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

evedon · 2020-03-10T14:07:44Z

TESTS/mbed_drivers/timeout/timeout_tests.h

@@ -201,8 +201,8 @@ void test_no_wait(void)
        Semaphore sem(0, 1);
        T timeout;
        timeout.attach_callback(mbed::callback(sem_callback, &sem), 0ULL);
-        int32_t sem_slots = sem.wait(0);
-        TEST_ASSERT_EQUAL(1, sem_slots);
+        bool sem_sts = sem.try_acquire_for(0);


Suggested change

bool sem_sts = sem.try_acquire_for(0);

bool sem_acquired = sem.try_acquire_for(0);

TEST_ASSERT_EQUAL(true, sem_acquired);

I suggest using a more meaningful variable name.

Idiomatically, it's better to use try_acquire() rather than try_acquire_for(0).

Doesn't matter much if mixing it with timed stuff, but in principle, try_acquire() gives you scope to omit timing code from bare metal builds, whereas the _for form forcibly includes it.

adbridge · 2020-03-11T11:34:35Z

CI started

mbed-ci · 2020-03-11T12:09:06Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-GCC_ARM

rajkan01 · 2020-03-11T16:39:43Z

there are two libraries are using deprecated Semaphore wait API that needs to be rebuilt for this PR:

targets/TARGET_WICED/TOOLCHAIN_ARMC6/TARGET_MTB_MXCHIP_EMW3166/libwiced_drivers.ar - @michalpasztamobica @AnttiKauppila

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/sdk/TOOLCHAIN_ARM/libublox-odin-w2-driver.ar
@ARMmbed/team-ublox

0xc0170 · 2020-03-16T15:13:08Z

@rajkan01 I remember seeing this commit somewhere else, in another PR, where was it? Did we receive any response there from teams?

Pull request has been modified.

evedon · 2020-03-17T15:02:04Z

@rajkan01 I remember seeing this commit somewhere else, in another PR, where was it? Did we receive any response there from teams?

The other PR is #12572 (comment)
So we might need the libary update in a separate PR.

tymoteuszblochmobica · 2020-03-17T23:33:22Z

Commit updated with cherry-pick #12609
tymoteuszblochmobica@7e146b0

rajkan01 · 2020-03-19T10:21:44Z

Commit updated with cherry-pick #12609
tymoteuszblochmobica/mbed-os@7e146b0

@tymoteuszblochmobica As discussed, please raise a separate PR as Your changes are not dependent on this PR.

adbridge · 2020-03-27T13:57:49Z

@0xc0170 @evedon @kjbracey-arm please re-review to confirm happy with updates

adbridge · 2020-03-27T13:58:39Z

CI restarted while awaiting review approvals

mbed-ci · 2020-03-27T18:07:37Z

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

0xc0170 · 2020-03-30T07:00:45Z

The job passed, the failures are not related to this test job (misconfig in CI).

0xc0170 · 2020-03-31T06:33:19Z

I'll fix the statuses and merge this one

0xc0170 · 2020-03-31T14:17:46Z

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/sdk/TOOLCHAIN_ARM/libublox-odin-w2-driver.ar

@rajkan01 Where is this one being tracked? I was just notified that ublox won't build on master today.

0xc0170 · 2020-03-31T14:19:29Z

cc @ARMmbed/team-ublox @MarceloSalazar

aqib-ublox · 2020-03-31T14:24:34Z

@0xc0170 our PR almost ready we would try tomorrow just some out of box testing remaing

ciarmcom requested review from evedon and a team March 10, 2020 14:00

ciarmcom added the needs: review label Mar 10, 2020

evedon reviewed Mar 10, 2020

View reviewed changes

rajkan01 force-pushed the semwait_remove_deprecation branch from 4646c05 to 06cfc1a Compare March 10, 2020 15:01

kjbracey previously approved these changes Mar 10, 2020

View reviewed changes

mergify bot added needs: CI and removed needs: review labels Mar 10, 2020

evedon previously approved these changes Mar 10, 2020

View reviewed changes

mergify bot added needs: work and removed needs: CI labels Mar 11, 2020

rajkan01 mentioned this pull request Mar 11, 2020

Upstream ble example cordio bluenrg ARMmbed/mbed-os-example-ble#287

Merged

0xc0170 previously approved these changes Mar 16, 2020

View reviewed changes

Remove Semaphore deprecated APIs

a6b78c6

rajkan01 force-pushed the semwait_remove_deprecation branch from 06cfc1a to a6b78c6 Compare March 16, 2020 16:37

tymoteuszblochmobica mentioned this pull request Mar 19, 2020

Rebuild WICED libraries after Mbed update #12659

Merged

adbridge added needs: CI and removed needs: work labels Mar 27, 2020

evedon approved these changes Mar 27, 2020

View reviewed changes

mergify bot added ready for merge needs: CI and removed needs: CI labels Mar 27, 2020

0xc0170 added mergify skip and removed needs: CI labels Mar 30, 2020

0xc0170 added release-version: 6.0.0-beta-1 BREAKING-CHANGE labels Mar 31, 2020

0xc0170 requested a review from bulislaw March 31, 2020 06:57

0xc0170 removed the mergify skip label Mar 31, 2020

0xc0170 removed the request for review from a team March 31, 2020 07:19

bulislaw approved these changes Mar 31, 2020

View reviewed changes

0xc0170 merged commit 8b92972 into ARMmbed:master Mar 31, 2020

mergify bot removed the ready for merge label Mar 31, 2020

qasim-ublox mentioned this pull request Apr 3, 2020

Update ODIN drivers to v3.8.0 RC1 #12756

Closed

	bool sem_sts = sem.try_acquire_for(0);
	bool sem_acquired = sem.try_acquire_for(0);
	TEST_ASSERT_EQUAL(true, sem_acquired);

Remove Semaphore deprecated APIs #12609

Remove Semaphore deprecated APIs #12609

Uh oh!

Conversation

rajkan01 commented Mar 10, 2020 • edited by evedon Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

ciarmcom commented Mar 10, 2020

Uh oh!

evedon Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

kjbracey Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

adbridge commented Mar 11, 2020

Uh oh!

mbed-ci commented Mar 11, 2020

Test run: FAILED

Uh oh!

rajkan01 commented Mar 11, 2020

Uh oh!

0xc0170 commented Mar 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

evedon commented Mar 17, 2020

Uh oh!

tymoteuszblochmobica commented Mar 17, 2020

Uh oh!

rajkan01 commented Mar 19, 2020

Uh oh!

adbridge commented Mar 27, 2020

Uh oh!

adbridge commented Mar 27, 2020

Uh oh!

mbed-ci commented Mar 27, 2020

Test run: SUCCESS

Uh oh!

0xc0170 commented Mar 30, 2020

Uh oh!

0xc0170 commented Mar 31, 2020

Uh oh!

0xc0170 commented Mar 31, 2020

Uh oh!

0xc0170 commented Mar 31, 2020

Uh oh!

aqib-ublox commented Mar 31, 2020

Uh oh!

Uh oh!

rajkan01 commented Mar 10, 2020 •

edited by evedon

Loading

0xc0170 commented Mar 16, 2020 •

edited

Loading