Skip to content

Cellular: Support EC2x power control pin support no connect #12624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2020
Merged

Cellular: Support EC2x power control pin support no connect #12624

merged 1 commit into from
Mar 16, 2020

Conversation

ccchang12
Copy link
Contributor

Summary of changes

In current EC2x driver, it is mandatory to provide a power control pin. But for EC21/EC25 PCI-E modules, the power control is done by H/W. So there is no power control pin, only have the reset control pin. Need to modify the code to support EC2x PCI-E modules.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@ciarmcom ciarmcom requested review from a team March 13, 2020 06:00
@ciarmcom
Copy link
Member

@ccchang12, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Mar 13, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 16, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 2a4e481 into ARMmbed:master Mar 16, 2020
@mergify mergify bot removed the ready for merge label Mar 16, 2020
@ccchang12 ccchang12 deleted the nuvoton_ec2x branch March 19, 2020 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ccchang12 @ciarmcom @0xc0170 @mbed-ci @AnttiKauppila @AriParkkila