Skip to content

Add "rtos-api" to bare metal #12629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Add "rtos-api" to bare metal #12629

merged 2 commits into from
Mar 26, 2020

Conversation

evedon
Copy link
Contributor

@evedon evedon commented Mar 16, 2020

Summary of changes

Added the bare metal form of the RTOS API since it doesn't add any overhead (except for a little extra compilation time) and has the benefit of minimising differences between RTOS and bare metal modes.

Impact of changes

RTOS APIs are available in bare metal mode.

Migration actions required

None

Documentation

Bare metal documentation needs to be updated. Work in progress for Mbed 6.


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@bulislaw @kjbracey-arm


@ciarmcom ciarmcom requested review from bulislaw, kjbracey and a team March 16, 2020 12:00
@ciarmcom
Copy link
Member

@evedon, thank you for your changes.
@bulislaw @kjbracey-arm @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Mar 19, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 19, 2020

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 19, 2020

test dynamic failure is known, will be fixed

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 25, 2020

dynamic test restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 25, 2020

Needs more reviews

@evedon
Copy link
Contributor Author

evedon commented Mar 25, 2020

@bulislaw should approve

@0xc0170 0xc0170 merged commit cb131c3 into ARMmbed:master Mar 26, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 26, 2020

Bare metal documentation needs to be updated. Work in progress for Mbed 6.

Is there already PR to be added here or will come soon?

@mergify mergify bot removed the ready for merge label Mar 26, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 26, 2020

[X] Major update (Breaking change E.g. Return code change / API behaviour change)

Isn't this minor update - adding new functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants