Skip to content

Cellular: Make Quectel EC2x modem start up timeout configurable #12651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2020
Merged

Cellular: Make Quectel EC2x modem start up timeout configurable #12651

merged 1 commit into from
Mar 24, 2020

Conversation

kivaisan
Copy link
Contributor

Summary of changes

Make Quectel EC2x modem start up timeout configurable

Fixes issue #12618

Impact of changes

Start up timeout can be configured via "QUECTEL_EC2X.start-timeout".
Default timeout also increase from 5sec to 15sec.

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-wan @mikaleppanen

Cellular: Make Quectel EC2x modem start up timeout configurable
4f7d775 
Default timeout also increase from 5sec to 15sec.
@ciarmcom ciarmcom requested review from mikaleppanen and a team March 19, 2020 12:00
@ciarmcom
Copy link
Member

@kivaisan, thank you for your changes.
@mikaleppanen @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 19, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Mar 19, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 19, 2020

Test run: FAILED

Summary: 2 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Mar 19, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 23, 2020

CI restarted

@mergify mergify bot added needs: CI and removed needs: work labels Mar 23, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 24, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 5d64e55 into ARMmbed:master Mar 24, 2020
@mergify mergify bot removed the ready for merge label Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@mikaleppanen mikaleppanen mikaleppanen approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kivaisan @ciarmcom @0xc0170 @mbed-ci @AnttiKauppila @mikaleppanen @AriParkkila