Removed all references to __CC_ARM #12654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
previously requested changes
Mar 19, 2020
kbarm
force-pushed
the
feature-remove-cc-arm-macro
branch
from
f3742b9 to
4465295
Compare
|
This PR only removed ARMC5 references from FEATURE_BLE, not platform. Could you amend the title & description? |
evedon
approved these changes
Mar 19, 2020
|
CI started |
Test run: SUCCESSSummary: 7 of 7 test jobs passed |
pan-
requested changes
Mar 20, 2020
| #elif defined(__CC_ARM) | ||
| #define BLE_DEPRECATED_API_USE_BEGIN() \ | ||
| _Pragma("push") \ | ||
| _Pragma("diag_suppress 1361") |
There was a problem hiding this comment.
Could you use the clang pragma instead when the file is compiled with ARMC6 ?
Please have a look at: http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0742b/chr1398848167694.html
| } | ||
|
|
||
| #elif defined ( __ICCARM__ ) | ||
| #if defined ( __ICCARM__ ) |
There was a problem hiding this comment.
Why not provide the proper replacement for ARM compiler 6 assembler ?
| ALIGN | ||
| } | ||
| #elif defined ( __GNUC__ ) | ||
| #if defined ( __GNUC__ ) |
There was a problem hiding this comment.
Is GCC assembly language compatible with ARMC6 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Removed ARMC5 reference from FEATURE_BLE.
ARM Compiler 5 is no longer supported in Mbed OS and is superseded by ARM Compiler 6
Impact of changes
Breaking change: The ARMC5 references are removed from platform as they have been deprecated in a previous Mbed OS release.
Migration actions required
Use Arm Compiler 6
Documentation
None.
Pull request type
Test results
Reviewers
@evedon