-
Notifications
You must be signed in to change notification settings - Fork 3k
Add check for return code in DeviceKey to avoid injecting invalid ROT #12667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@boomer41, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@teetak01 , @JanneKiiskila , @JammuKekkonen for your information. |
CI started |
Test run: FAILEDSummary: 1 of 7 test jobs failed Failed test jobs:
|
Summary of changes
Check return code of the random generator before injecting the root of trust.
Without this check, an invalid - and therefore insecure - ROT may be used like in #9278.
This bug was introduced in #12385.
Impact of changes
Invalid ROTs won't be used.
Migration actions required
None. This bug was introduced in the v6-alpha and therefore isn't critical as the alpha may not be used for production devices.
Documentation
None. This bug was introduced in the v6-alpha and therefore isn't critical as the alpha may not be used for production devices.
Pull request type
Test results