Skip to content

ESP8266: Fix typo: gateway to netmask #12670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2020
Merged

ESP8266: Fix typo: gateway to netmask #12670

merged 1 commit into from
Mar 30, 2020

Conversation

michalpasztamobica
Copy link
Contributor

Summary of changes

Fixes #12546.

ESP8266 driver has a typo since deprecated API removal (I typed gateway instead of netmask).

Impact of changes

None, other than netmask gets returned correctly.

Migration actions required

None

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@star297
@AnttiKauppila

@ciarmcom ciarmcom requested review from AnttiKauppila and a team March 23, 2020 16:00
@ciarmcom
Copy link
Member

@michalpasztamobica, thank you for your changes.
@AnttiKauppila @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 23, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Mar 23, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 23, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Mar 23, 2020
@michalpasztamobica
Copy link
Contributor Author

The failing platform is DISCO_L475VG_IOT01A. It doesn't have ESP8266. I think the failure is not related to these changes.

@michalpasztamobica
Copy link
Contributor Author

@0xc0170 I don't think this need any work - the failure is the memory card issue, most likely HW-related.
@AnttiKauppila , would you do a code review, please?

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 25, 2020

Correct, test was restarted and all green, once reviewed , can go in

@adbridge
Copy link
Contributor

CI ran 3 days ago so re-running

@mbed-ci
Copy link

mbed-ci commented Mar 26, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 26, 2020

I aborted the old one, the new one should be in the queue now

@mbed-ci
Copy link

mbed-ci commented Mar 26, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Mar 26, 2020
@michalpasztamobica
Copy link
Contributor Author

I restarted the job and it passed (failures were totally unrelated)

@0xc0170 0xc0170 merged commit 451bd06 into ARMmbed:master Mar 30, 2020
@mergify mergify bot removed the ready for merge label Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESP8266 network connection stat's not working since string based API's depreciated
6 participants
@michalpasztamobica @ciarmcom @0xc0170 @mbed-ci @adbridge @AnttiKauppila