Skip to content

Netsocket/lwIP Stack: Remove support for ARM Compiler 5 #12671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2020
Merged

Netsocket/lwIP Stack: Remove support for ARM Compiler 5 #12671

merged 1 commit into from
Apr 20, 2020

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

ARM Compiler 5 is no longer actively supported and was superseded in
Mbed OS by ARM Compiler 6.

Impact of changes

Breaking change: The binary generated from ARM Compiler 5 cannot be relied on as support has been dropped.

Migration actions required

Use Arm Compiler 6.

Documentation

N/A

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@AnttiKauppila @evedon @bulislaw

@ciarmcom ciarmcom requested review from AnttiKauppila, bulislaw, evedon and a team March 23, 2020 16:00
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@evedon @bulislaw @AnttiKauppila @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-mesh @ARMmbed/mbed-os-ipcore please review.

0xc0170
0xc0170 previously approved these changes Mar 24, 2020
View reviewed changes
@mbed-ci
Copy link

mbed-ci commented Mar 24, 2020

Test run: FAILED

Summary: 2 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_wisun-mesh-test
  • jenkins-ci/mbed-os-ci_greentea-test

@hugueskamba
Copy link
Collaborator Author

Test run: FAILED

Summary: 2 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_wisun-mesh-test
  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170 I think there might be a DISCO_L475VG_IOT01A hardware issue. I ran the failing test (tests-mbed_platform-error_handling) locally and it passed.

evedon
evedon reviewed Mar 25, 2020
View reviewed changes
features/frameworks/nanostack-libservice/mbed-client-libservice/ns_types.h
@@ -117,10 +115,7 @@ typedef int_fast32_t int_fast24_t;

/* C11's "alignas" macro, emulated for integer expressions if necessary */
#ifndef __alignas_is_defined
#if defined __CC_ARM || defined __TASKING__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be

#if defined __TASKING__

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

features/frameworks/nanostack-libservice/mbed-client-libservice/ns_types.h
@@ -149,11 +144,7 @@ typedef int_fast32_t int_fast24_t;
* static int foo(void) MAYBE_UNUSED;
* ~~~
*/
#if defined __CC_ARM || defined __GNUC__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be

#if defined __GNUC__

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@hugueskamba
Netsocket/lwIP Stack: Remove support for ARM Compiler 5
209f1e6 
ARM Compiler 5 is no longer actively supported and was superseded in
Mbed OS by ARM Compiler 6.
@hugueskamba hugueskamba force-pushed the hk-netsocket-remove-armc5-support branch from ec33c1d to 209f1e6 Compare March 31, 2020 09:54
@mergify mergify bot dismissed 0xc0170’s stale review March 31, 2020 09:55

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2020

@ARMmbed/mbed-os-ipcore Please review

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 4, 2020

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 9, 2020

I'll restart CI later today

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 9, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 9, 2020

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 14, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 14, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 4
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 14, 2020

@artokin @kjbracey-arm Can you review?

Once approved, this will be merged.

artokin
artokin reviewed Apr 20, 2020
View reviewed changes
Copy link
Contributor

@artokin artokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kjbracey
kjbracey approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@kjbracey kjbracey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for Mbed OS - I guess we're also okay for doing this for Nanostack libservice upstream?

@0xc0170 0xc0170 merged commit 27405bf into ARMmbed:master Apr 20, 2020
@mergify mergify bot removed the ready for merge label Apr 20, 2020
@hugueskamba hugueskamba deleted the hk-netsocket-remove-armc5-support branch April 20, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evedon evedon evedon left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

@kjbracey kjbracey kjbracey approved these changes

@artokin artokin artokin approved these changes

@AnttiKauppila AnttiKauppila Awaiting requested review from AnttiKauppila

@bulislaw bulislaw Awaiting requested review from bulislaw

Assignees
No one assigned
Labels
BREAKING-CHANGE release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hugueskamba @ciarmcom @mbed-ci @0xc0170 @kjbracey @artokin @evedon