Mergify update #12673
Merged
Mergify update #12673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. If a PR is closed but not merged then remove all labels 2. If a release version is added and there are release version missing or Release review required, then remove those labels 3. In the check for conflicts rule, add the condition 'open' so that it isn't applied to closed or merged PRs
|
@adbridge, thank you for your changes. |
0xc0170
reviewed
Mar 23, 2020
.mergify.yml
Outdated
| - name: release version is a must for merged PRs part 2 | ||
| conditions: | ||
| - merged | ||
| - -label=^(release-version) |
There was a problem hiding this comment.
this shouldn't be - label=^(release-version) - otherwise its negative (not release label and merged) ?
There was a problem hiding this comment.
Ah yes it should be
Pr is merged and a label beginning with 'release-version' is present. I missed the extra '-'
There was a problem hiding this comment.
Should now be fixed
|
@adbridge, thank you for your changes. |
0xc0170
approved these changes
Mar 23, 2020
|
CI started |
0xc0170
added
release-version: 6.0.0-beta-1
ready for merge
and removed
needs: review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
A number of Mergify rules were not quite working as expected. This update fixes them and adds a new rule.
Impact of changes
Mergify rules work correctly
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers