-
Notifications
You must be signed in to change notification settings - Fork 3k
MBED TRACE default level is INFO #12682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jeromecoutant, thank you for your changes. |
@SeppoTakalo @AnttiKauppila @evedon @jamesbeyond Please review |
@teetak01 Does this affect client tests? I'm OK to accept, but I don't know how many test cases rely on extra verbose trace level, so this might have regression on those.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont have details why debug was selected as default, info should be sufficient as a starting point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok. Our applications are already controlling the trace-levels when needed.
It would be good to make the same change also to https://github.com/armmbed/mbed-trace
CI started |
CI internal error, will restart once fixed cc @ARMmbed/mbed-os-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could use even TRACE_LEVEL_ERROR as a default value
Seems reasonnable to start with INFO. Perhaps next step could be ERROR as Antti suggests. |
Test run: FAILEDSummary: 1 of 6 test jobs failed Failed test jobs:
|
Summary of changes
Current default trace level is DEBUG meaning all.
I think default trace level could be INFO, up to each user to manually set more details.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers