Skip to content

MBED TRACE default level is INFO #12682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Current default trace level is DEBUG meaning all.
I think default trace level could be INFO, up to each user to manually set more details.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested a review from a team March 24, 2020 10:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 25, 2020

@SeppoTakalo @AnttiKauppila @evedon @jamesbeyond Please review

@SeppoTakalo
Copy link
Contributor

@teetak01 Does this affect client tests?

I'm OK to accept, but I don't know how many test cases rely on extra verbose trace level, so this might have regression on those..

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont have details why debug was selected as default, info should be sufficient as a starting point.

@0xc0170 0xc0170 requested a review from teetak01 March 25, 2020 08:43
@mergify mergify bot added needs: CI and removed needs: review labels Mar 25, 2020
Copy link
Contributor

@teetak01 teetak01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. Our applications are already controlling the trace-levels when needed.

It would be good to make the same change also to https://github.com/armmbed/mbed-trace

@teetak01 teetak01 requested a review from tommikas March 25, 2020 08:56
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 25, 2020

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 25, 2020

CI internal error, will restart once fixed

cc @ARMmbed/mbed-os-test

Copy link

@AnttiKauppila AnttiKauppila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could use even TRACE_LEVEL_ERROR as a default value

@evedon
Copy link
Contributor

evedon commented Mar 25, 2020

Seems reasonnable to start with INFO. Perhaps next step could be ERROR as Antti suggests.

@mbed-ci
Copy link

mbed-ci commented Mar 25, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@jeromecoutant jeromecoutant deleted the PR_TRACELEVEL branch March 31, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants