-
Notifications
You must be signed in to change notification settings - Fork 3k
Storage: Remove support for ARM Compiler 5 #12699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage: Remove support for ARM Compiler 5 #12699
Conversation
ARM Compiler 5 is no longer actively supported and was superseded in Mbed OS by ARM Compiler 6.
@hugueskamba, thank you for your changes. |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the benefit of doing this?
LittleFS might be used on other projects using Arm C 5..
We should not actively try to prevent people using it, even if OS does not support it anymore.
Hi @SeppoTakalo , Based on this comment, no further changes will be made on this PR. Please remove the change request if you do not have any other comment. |
@hugueskamba As littlefs as well si out of this tree, shall this be closed? |
@0xc0170 , I believe the decision was made to allow the PR as is (#12699 (comment)). |
We should try to simplify the code base and remove dead code as much as possible. An exception could be made but given that Seppo is okay with the PR, I think it should go ahead. |
OK, will clear statuses and restart CI later |
CI started |
Test run: FAILEDSummary: 1 of 6 test jobs failed Failed test jobs:
|
CI restarted |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
Summary of changes
ARM Compiler 5 is no longer actively supported and was superseded in
Mbed OS by ARM Compiler 6.
Impact of changes
Breaking change: The binary generated from ARM Compiler 5 cannot be relied on as support has been dropped.
Migration actions required
Use Arm Compiler 6.
Documentation
N/A
Pull request type
Test results
Reviewers
@SeppoTakalo