Skip to content

Storage: Remove support for ARM Compiler 5 #12699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

ARM Compiler 5 is no longer actively supported and was superseded in
Mbed OS by ARM Compiler 6.

Impact of changes

Breaking change: The binary generated from ARM Compiler 5 cannot be relied on as support has been dropped.

Migration actions required

Use Arm Compiler 6.

Documentation

N/A


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@SeppoTakalo


ARM Compiler 5 is no longer actively supported and was superseded in
Mbed OS by ARM Compiler 6.
@ciarmcom ciarmcom requested review from SeppoTakalo and a team March 25, 2020 18:00
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@SeppoTakalo @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@mbed-ci
Copy link

mbed-ci commented Mar 26, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

Copy link
Contributor

@SeppoTakalo SeppoTakalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the benefit of doing this?

LittleFS might be used on other projects using Arm C 5..
We should not actively try to prevent people using it, even if OS does not support it anymore.

@hugueskamba
Copy link
Collaborator Author

What is the benefit of doing this?

LittleFS might be used on other projects using Arm C 5..
We should not actively try to prevent people using it, even if OS does not support it anymore.

Hi @SeppoTakalo ,

Based on this comment, no further changes will be made on this PR. Please remove the change request if you do not have any other comment.
Thanks

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2020

@hugueskamba As littlefs as well si out of this tree, shall this be closed?

@hugueskamba
Copy link
Collaborator Author

@hugueskamba As littlefs as well si out of this tree, shall this be closed?

@0xc0170 , I believe the decision was made to allow the PR as is (#12699 (comment)).
@evedon Can you confirm?

@evedon
Copy link
Contributor

evedon commented Apr 3, 2020

@hugueskamba As littlefs as well si out of this tree, shall this be closed?

@0xc0170 , I believe the decision was made to allow the PR as is (#12699 (comment)).
@evedon Can you confirm?

We should try to simplify the code base and remove dead code as much as possible. An exception could be made but given that Seppo is okay with the PR, I think it should go ahead.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2020

OK, will clear statuses and restart CI later

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 4, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 14, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 14, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 merged commit ee476d9 into ARMmbed:master Apr 15, 2020
@mergify mergify bot removed the ready for merge label Apr 15, 2020
@hugueskamba hugueskamba deleted the hk_remove_armc5_support_storage branch June 30, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants