Skip to content

M487: Update BSP #12716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 15, 2020
Merged

M487: Update BSP #12716

merged 3 commits into from
Apr 15, 2020

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Mar 30, 2020

Summary of changes

This PR updates BSP for M480 series targets and makes relevant modifications:

  1. Support degrading QSPI0/1 to SPI4/5 for normal SPI transfer
  2. Fix with BSP crypto driver API change
  3. Fix with BSP PDMA driver API change
  4. Make necessary modifications to pass FPGA CI Test Shield tests

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@ciarmcom ciarmcom requested review from Ronny-Liu and a team March 30, 2020 11:00
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@Ronny-Liu @ARMmbed/mbed-os-crypto @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 30, 2020

Looks fine, there are still 4 license issues in licence_check:

File: /features/mbedtls/targets/TARGET_NUVOTON/TARGET_M480/aes/aes_alt.c reason: Missing SPDX license identifier
File: /features/mbedtls/targets/TARGET_NUVOTON/TARGET_M480/des/des_alt.c reason: Missing SPDX license identifier
File: /features/mbedtls/targets/TARGET_NUVOTON/TARGET_M480/ecp/ecp_internal_alt.c reason: Missing SPDX license identifier
File: /features/mbedtls/targets/TARGET_NUVOTON/TARGET_M480/sha/sha_alt_hw.c reason: Missing SPDX license identifier

Please review

@ccli8 ccli8 force-pushed the nuvoton_m487_bsp branch from 5a59476 to 5ef71ea Compare March 31, 2020 02:35
@ccli8
Copy link
Contributor Author

ccli8 commented Mar 31, 2020

Looks fine, there are still 4 license issues in licence_check:

@0xc0170 Fixed license issue

0xc0170
0xc0170 previously approved these changes Mar 31, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Mar 31, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 31, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 1, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Apr 1, 2020
ccli8 added 3 commits April 1, 2020 13:55
@ccli8
M487: Update BSP
3b9492f 
Relevant modifications:
1. Support degrading QSPI0/1 to SPI4/5 for normal SPI transfer
2. Fix with BSP crypto driver API change
3. Fix with BSP PDMA driver API change
4. Make necessary modifications to pass FPGA CI Test Shield tests
5. Don't distinguish pinmap among parts e.g. M480 LG. Application users must take care.
@ccli8
M487: Add SPDX license identifier
d709c77
@ccli8
M487: Add SPDX license identifier for BSP files
2c9ec8f
@ccli8 ccli8 force-pushed the nuvoton_m487_bsp branch from 5ef71ea to 2c9ec8f Compare April 1, 2020 06:32
@mergify mergify bot dismissed 0xc0170’s stale review April 1, 2020 06:32

Pull request has been modified.

@ccli8
Copy link
Contributor Author

ccli8 commented Apr 1, 2020

Make modifications:

  1. Do rebase
  2. Fix SPI FIFO depth with BSP update

@mbed-ci
Copy link

mbed-ci commented Apr 6, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@ccli8
Copy link
Contributor Author

ccli8 commented Apr 10, 2020

The failure seems not related to this PR. Update?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 14, 2020

CI restarted (the last week we had 5.15 CI jobs most of the time in)

@mbed-ci
Copy link

mbed-ci commented Apr 14, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 merged commit 68f1ef2 into ARMmbed:master Apr 15, 2020
@mergify mergify bot removed the ready for merge label Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@Ronny-Liu Ronny-Liu Awaiting requested review from Ronny-Liu

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccli8 @ciarmcom @0xc0170 @mbed-ci