Testing: Fix multihoming test compilation issues

[kivaisan]

Summary of changes

Fix multihoming test compilation issues.

• TEST_ASSERT_EQUAL compares int values and converting SocketAddress as int is not supported.
• TRACE_GROUP was missing preventing trace builds
• Workaround for SocketAddress _ip_address.reset() compilation problem with IAR.

Fixes #12720

Impact of changes

Migration actions required

Documentation

None

---

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

---

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

---

Reviewers

---

[0xc0170]

@kivaisan Thanks for fixing this quickly. Is this breakage also present in the latest nightly?

[0xc0170]

Answer to my question - I realized I was looking earlier today at the logs and saw it

Build failures:
  * UBLOX_EVK_ODIN_W2::ARMC6::TESTS-NETWORK-MULTIHOMING
        Building project multihoming (UBLOX_EVK_ODIN_W2, ARMC6)
        Scan: ARM
        Scan: multihoming
        Compile [ 25.0%]: main.cpp
        [Warning] LWIPStack.h@300,27: 'get_ip_address' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
        [Error] main.cpp@84,5: cannot convert 'SocketAddress' to '_U_SINT' (aka 'long long') without a conversion operator
        [Error] main.cpp@84,5: cannot convert 'SocketAddress' to '_U_SINT' (aka 'long long') without a conversion operator
        [Error] main.cpp@115,9: cannot convert 'SocketAddress' to '_U_SINT' (aka 'long long') without a conversion operator
        [Error] main.cpp@115,9: cannot convert 'SocketAddress' to '_U_SINT' (aka 'long long') without a conversion operator

[0xc0170]

CI started

[kjbracey]

Thanks for fix. IAR's library has a bug in its array-type unique_ptr - it's got a missing reset overload. Should report that - @0xc0170, do you remember your bug report login? :)

That TEST_ASSERT_EQUAL thing was a great example of why SocketAddress shouldn't have had a non-explicit operator bool, and what adding the explicit was intended to catch.

It compiled, but didn't do what you wanted; it converted each address to bool and compared the bools, not the addresses.

[mbed-ci]

Test run: FAILED

Summary: 2 of 6 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

• jenkins-ci/mbed-os-ci_cloud-client-pytest
• jenkins-ci/mbed-os-ci_greentea-test

Pull request has been modified.

[kivaisan]

@kjbracey-arm @0xc0170 reset(nullptr) doesn't seem to work either, so do you have any idea how to handle IAR issue?

I removed it from this PR and added multihoming trace build fix.

[kivaisan]

IAR compilation issue now also fixed. This is now ready for review & CI.

[0xc0170]

CI started

[mbed-ci]

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

• jenkins-ci/mbed-os-ci_greentea-test

[MarceloSalazar]

Note we should be applying these changes to the 5.15 branch too, as that's where we'll continue to support the Ublox ODIN platform.

[kivaisan]

Note we should be applying these changes to the 5.15 branch too, as that's where we'll continue to support the Ublox ODIN platform.

No necessarily:

• TEST_ASSERT_EQUAL actually does not check the correct thing, but is this so critical that should be fixed in 5.15. I leave it to maintainers to decide.
• TRACE_GROUP build issue occurs only when mbed trace is enabled. By default traces are not enabled for tests. So I don't see this that critical at all.
• unique_ptr::reset workaround is a regression from mbed-os 6 SocketAddress refactoring. Therefore does not apply to mbed-os 5.15.

[kivaisan]

@0xc0170 NUCLEO_F429ZI GCC_ARM tests-netsocket-tls failure looks like a random start up failure. Could you just restart the CI?

[mbed-ci]

Test run: FAILED

Summary: 3 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

• jenkins-ci/mbed-os-ci_build-ARM-lts
• jenkins-ci/mbed-os-ci_build-GCC_ARM-lts
• jenkins-ci/mbed-os-ci_unittests-lts

[0xc0170]

CI restarted, will clean lts test (not the one for this PR)

[mbed-ci]

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 3
Build artifacts