Skip to content

Remove Mbed SPM #12738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Remove Mbed SPM #12738

merged 2 commits into from
Apr 16, 2020

Conversation

Patater
Copy link
Contributor

@Patater Patater commented Mar 31, 2020

Summary of changes

Remove FUTURE_SEQUANA and FUTURE_SEQUANA_M0 targets. These are not supported in Mbed 6.

After the removal of FUTURE_SEQUANA targets, there are no targets remaining that use Mbed SPM. Remove Mbed SPM as well, as it is unused.

Impact of changes

The following targets are being removed in Mbed 6:

  • FUTURE_SEQUANA
  • FUTURE_SEQUANA_M0

Migration actions required

Please use a version of Mbed OS 5 if you require support for FUTURE_SEQUANA or FUTURE_SEQUANA_M0

Documentation

None


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@Devran01 @jainvikas8


@ciarmcom ciarmcom requested review from urutva, jainvikas8, maclobdell and a team March 31, 2020 19:00
@ciarmcom
Copy link
Member

@Patater, thank you for your changes.
@maclobdell @jainvikas8 @Devran01 @ARMmbed/mbed-os-core @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from a team April 1, 2020 07:56
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 1, 2020

This should resolve #12732 (one of the targets do not compile anymore).

0xc0170
0xc0170 previously approved these changes Apr 1, 2020
@0xc0170 0xc0170 requested review from bulislaw and removed request for a team April 1, 2020 07:57
@mergify mergify bot added needs: CI and removed needs: review labels Apr 1, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 1, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 1, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 2, 2020

Failures not related, being tracked separately. Restarting tests

@mergify mergify bot added needs: work and removed needs: CI labels Apr 2, 2020
@mergify
Copy link

mergify bot commented Apr 2, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 9, 2020

I started CI but will fail, rebase needed

Patater added 2 commits April 16, 2020 14:10
FUTURE_SEQUANA targets are no longer supported. Remove the target from
Mbed.

Signed-off-by: Jaeden Amero <[email protected]>
All MBED_SPM targets have been removed previously, via commits
5cc6628 ("PSOC6: remove PSA targets") and 115b09a ("psoc6:
Remove FUTURE_SEQUANA and FUTURE_SEQUANA_M0"). Remove all the dead
MBED_SPM code, as no targets use it.

Signed-off-by: Jaeden Amero <[email protected]>
@mergify mergify bot dismissed 0xc0170’s stale review April 16, 2020 13:11

Pull request has been modified.

@Patater
Copy link
Contributor Author

Patater commented Apr 16, 2020

Rebased on latest master. No other changes.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 16, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 16, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 merged commit 8fea81a into ARMmbed:master Apr 16, 2020
@mergify mergify bot removed the ready for merge label Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants