Skip to content

add config option for phy media interface #12745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

JojoS62
Copy link
Contributor

@JojoS62 JojoS62 commented Apr 2, 2020

Summary of changes

This PR extends #12464
by the option for the hardware phy connection. The default is set to RMII and could not be changed for custom targets. This PR adds an option to select RMII or MII interface (probably others, but not tested).

Impact of changes

This option does not change compatibility and has no impact on generated code when using default.
For using the MII interface, the custom init code has to be changed. This code is placed in stm32xx_eth_init.c and is target dependent and can be placed in a custom target extension.

Migration actions required

Documentation

This PR uses the standard Mbed configuration via mbed_app.json.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Applies to custom targets that use different than RMII phy hardware connection.
The modification was tested on custom hardware with DP83848 phy and STM32F407VG MCU.


Reviewers

@jeromecoutant

@ciarmcom ciarmcom requested review from jeromecoutant and a team April 2, 2020 11:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 2, 2020

@JojoS62, thank you for your changes.
@jeromecoutant @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 5, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 6, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Apr 6, 2020
@JojoS62
Copy link
Contributor Author

JojoS62 commented Apr 6, 2020

it looks like there were problems with memory size, but not related to this PR. The failing test is about F303 which has no Ethernet.

@mergify mergify bot added needs: CI and removed needs: work labels Apr 7, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 9, 2020

Will restart tests later today

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 9, 2020

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 14, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 14, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 merged commit 90db09e into ARMmbed:master Apr 15, 2020
@mergify mergify bot removed the ready for merge label Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants