-
Notifications
You must be signed in to change notification settings - Fork 3k
add config option for phy media interface #12745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@JojoS62, thank you for your changes. |
CI started |
Test run: FAILEDSummary: 1 of 6 test jobs failed Failed test jobs:
|
it looks like there were problems with memory size, but not related to this PR. The failing test is about F303 which has no Ethernet. |
Will restart tests later today |
CI started |
CI restarted |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
Summary of changes
This PR extends #12464
by the option for the hardware phy connection. The default is set to RMII and could not be changed for custom targets. This PR adds an option to select RMII or MII interface (probably others, but not tested).
Impact of changes
This option does not change compatibility and has no impact on generated code when using default.
For using the MII interface, the custom init code has to be changed. This code is placed in stm32xx_eth_init.c and is target dependent and can be placed in a custom target extension.
Migration actions required
Documentation
This PR uses the standard Mbed configuration via mbed_app.json.
Pull request type
Test results
Applies to custom targets that use different than RMII phy hardware connection.
The modification was tested on custom hardware with DP83848 phy and STM32F407VG MCU.
Reviewers
@jeromecoutant