Skip to content

Fix build failure due to C lib selected #12748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2020
Merged

Fix build failure due to C lib selected #12748

merged 1 commit into from
Apr 15, 2020

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

Allow target.c_lib to be set to small when Mbed 5 is supported.

Impact of changes

It is possible to set target.c_lib to "small" in targets.json when a target supports Mbed OS 5.

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @rajkan01 @madchutney @mark-edgeworth

@hugueskamba
Fix build failure due to C lib selected
467305f 
Allow target.c_lib to be set to small when Mbed 5 is supported.
@hugueskamba hugueskamba mentioned this pull request Apr 2, 2020
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 2, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 2, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added the needs: work label Apr 2, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2020

Known issue, restarting test

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 14, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 14, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 35c9301 into ARMmbed:master Apr 15, 2020
@mergify mergify bot removed the ready for merge label Apr 15, 2020
@hugueskamba hugueskamba deleted the hk_fix_c_lib_build_failure branch June 30, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@evedon evedon evedon approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hugueskamba @0xc0170 @mbed-ci @evedon