Skip to content

Update astyle filtering rules for Nanostack #12755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2020
Merged

Update astyle filtering rules for Nanostack #12755

merged 1 commit into from
Apr 16, 2020

Conversation

artokin
Copy link
Contributor

@artokin artokin commented Apr 3, 2020 •
edited
Loading

Summary of changes

Remove some nanostack related components from astyle ignore rules:

  • 802.15.4 RF drivers
  • features/nanostack/coap-service
  • features/nanostack/sal-stack-nanostack, (mdns related code still ignored)

This PR requires #12754

Impact of changes

If Nanostack code is changed, then Mbed OS coding style will be automatically followed.

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@artokin artokin changed the title Update astyle filtering rules Update astyle filtering rules for Nanostack Apr 3, 2020
Update astyle filtering rules
14de0f0 
Enable astyle for:
-components/802.15.4
-features/nanostack/coap-service

Allow astyle formatting for sal-stack-nanostack, except:
-features/nanostack/sal-stack-nanostack/source/Service_Libs/mdns/fnet
@artokin artokin force-pushed the update_astyle_filtering_rules branch from f161cf3 to 14de0f0 Compare April 3, 2020 13:29
@ciarmcom ciarmcom requested a review from a team April 3, 2020 15:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 3, 2020

@artokin, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like seeing this type of changes

@artokin
Copy link
Contributor Author

artokin commented Apr 15, 2020

@0xc0170 , I added dependency to preceding PR by mistake. I double checked coding-style on my workarea and no dependency exists. As tests are passing this PR is ready for merge.

@0xc0170 0xc0170 merged commit 3f4e8e5 into ARMmbed:master Apr 16, 2020
@mergify mergify bot removed the ready for merge label Apr 16, 2020
@artokin artokin deleted the update_astyle_filtering_rules branch April 16, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artokin @ciarmcom @0xc0170