Skip to content

Add I2C api to Musca-B1 target #12778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2020
Merged

Add I2C api to Musca-B1 target #12778

merged 1 commit into from
Apr 15, 2020

Conversation

GaborAbonyi
Copy link
Contributor

@GaborAbonyi GaborAbonyi commented Apr 8, 2020 •
edited
Loading

Summary of changes

This commit adds support for I2C controller on Musca-B1 target.

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested review from ashok-rao and a team April 8, 2020 17:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 8, 2020

@GaborAbonyi, thank you for your changes.
@ashok-rao @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Apr 9, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Apr 9, 2020
ashok-rao
ashok-rao approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@ashok-rao ashok-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't ran any tests but overall LGTM! Thank you.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 14, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Apr 14, 2020
@mbed-ci
Copy link

mbed-ci commented Apr 14, 2020

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@GaborAbonyi
Copy link
Contributor Author

Checked the CI logs. I should have caught that issue locally, sorry about that. Will upload the fix tomorrow.

@GaborAbonyi
Add I2C api to Musca-B1 target
b442e35 
Change-Id: Iab5a76e6b8ea28933b39b4ec4ee753f45e5bfcc7
Signed-off-by: Gabor Abonyi <[email protected]>
@GaborAbonyi GaborAbonyi force-pushed the add_i2c_to_musca_b1 branch from 6f08e2e to b442e35 Compare April 15, 2020 09:19
@mergify mergify bot dismissed 0xc0170’s stale review April 15, 2020 09:19

Pull request has been modified.

@GaborAbonyi
Copy link
Contributor Author

GaborAbonyi commented Apr 15, 2020 •
edited
Loading

I uploaded the fix, i2c_api.c was missing some pinmap getter interface. The other files are the same.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 15, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 15, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 4c08455 into ARMmbed:master Apr 15, 2020
@mergify mergify bot removed the ready for merge label Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@ashok-rao ashok-rao ashok-rao approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GaborAbonyi @ciarmcom @0xc0170 @mbed-ci @ashok-rao