Skip to content

Cellular: Fix build problem if cellular.debug-at is set as null #12815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2020
Merged

Cellular: Fix build problem if cellular.debug-at is set as null #12815

merged 1 commit into from
Apr 16, 2020

Conversation

kivaisan
Copy link
Contributor

@kivaisan kivaisan commented Apr 16, 2020 •
edited
Loading

Summary of changes

Fix build problem if cellular.debug-at is set as null in mbed_app.json

Also improved help for debug-at setting.

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-wan

@kivaisan kivaisan changed the title Cellular: Fix build problem if cellular.debug-at is as null Cellular: Fix build problem if cellular.debug-at is set as null Apr 16, 2020
@ciarmcom
Copy link
Member

@kivaisan, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team April 16, 2020 11:00
@mergify mergify bot added needs: CI and removed needs: review labels Apr 16, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 16, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 16, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 7f4dc90 into ARMmbed:master Apr 16, 2020
@mergify mergify bot removed the ready for merge label Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jarvte jarvte jarvte approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kivaisan @ciarmcom @0xc0170 @mbed-ci @jarvte