Skip to content

Turn on ARM linker --inline #12825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Turn on ARM linker --inline #12825

merged 1 commit into from
Apr 23, 2020

Conversation

kjbracey
Copy link
Contributor

Summary of changes

For release and develop profiles, turn on the linker's --inline
optimisation. This can save a couple of hundred bytes in a typical
image.

The optimisation replaces branches to small functions with the
inlined code from those functions. And it's possible that the
out-of-line functions can be eliminated.

Setting confined to release and develop builds only, as it can lead to
invalid debug information.

Impact of changes

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


For release and develop profiles, turn on the linker's `--inline`
optimisation. This can save a couple of hundred bytes in a typical
image.

The optimisation replaces branches to small functions with the
inlined code from those functions. And it's possible that the
out-of-line functions can be eliminated.

Setting confined to release and develop builds only, as it can lead to
invalid debug information.
@ciarmcom
Copy link
Member

@kjbracey-arm, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team April 17, 2020 11:00
@0xc0170 0xc0170 requested a review from a team April 17, 2020 11:48
@mergify mergify bot added needs: CI and removed needs: review labels Apr 17, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 17, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 17, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2020

test restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2020

Test failures not related, will restart CI later today

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 21, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 21, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 21, 2020

@ARMmbed/mbed-os-core @ARMmbed/mbed-os-tools Please review

Copy link
Contributor

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170 0xc0170 merged commit ecf4008 into ARMmbed:master Apr 23, 2020
@kjbracey kjbracey deleted the linkinline branch April 23, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants