Skip to content

TEST: Update example test #12849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2020
Merged

TEST: Update example test #12849

merged 3 commits into from
May 5, 2020

Conversation

jamesbeyond
Copy link
Contributor

@jamesbeyond jamesbeyond commented Apr 22, 2020

Summary of changes

This PR update following example test:

  • enabled wifi example test
  • enabled nfc example test
  • change the target that runs filesystem example, which increases the stability by using internal flash rather than SD card

Impact of changes

Migration actions required

Documentation

Not required


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested review from a team April 22, 2020 17:00
@ciarmcom
Copy link
Member

@jamesbeyond, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Apr 23, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 23, 2020

one question: as it was, k64f was defined to use sd card by default? Can it be changed somehow - so would keep the same targets just different config?

@jamesbeyond
Copy link
Contributor Author

one question: as it was, k64f was defined to use sd card by default? Can it be changed somehow - so would keep the same targets just different config?

I guess it is not easy, as K64F not having other onboard storage devices, where that DISCO target has a SPI flash

@mergify mergify bot dismissed 0xc0170’s stale review April 23, 2020 19:34

Pull request has been modified.

@mergify mergify bot added needs: CI and removed needs: review labels Apr 24, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 27, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 27, 2020

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 27, 2020

I am now checking the error, its with example, one of the PRs needs to get in to fix it. I'll start CI later

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 28, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 28, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 28, 2020

@jamesbeyond let us know when we should integrate this. Due to the resources in the next 2 weeks, I am not certain if this should be on hold or shall proceed?

@evedon
Copy link
Contributor

evedon commented May 1, 2020

Can @VeliMattiLahtela tell us if thhis PR can be merged?

@jamesbeyond
Copy link
Contributor Author

@jamesbeyond let us know when we should integrate this. Due to the resources in the next 2 weeks, I am not certain if this should be on hold or shall proceed?

yes, please go ahead and merge this. this can be merged. they have been tested pass locally.

@evedon
Copy link
Contributor

evedon commented May 5, 2020

@0xc0170 @adbridge please mark as ready for merge

@adbridge
Copy link
Contributor

adbridge commented May 5, 2020

@andypowers as this appears to add automated testing for Wifi and NFC I would suggest this is worth taking into beta ?

@0xc0170 0xc0170 merged commit 9501ccd into ARMmbed:master May 5, 2020
@mergify mergify bot removed the ready for merge label May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants