-
Notifications
You must be signed in to change notification settings - Fork 3k
TEST: Update example test #12849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST: Update example test #12849
Conversation
@jamesbeyond, thank you for your changes. |
one question: as it was, k64f was defined to use sd card by default? Can it be changed somehow - so would keep the same targets just different config? |
I guess it is not easy, as K64F not having other onboard storage devices, where that DISCO target has a SPI flash |
CI started |
Test run: FAILEDSummary: 2 of 3 test jobs failed Failed test jobs:
|
I am now checking the error, its with example, one of the PRs needs to get in to fix it. I'll start CI later |
CI started |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
@jamesbeyond let us know when we should integrate this. Due to the resources in the next 2 weeks, I am not certain if this should be on hold or shall proceed? |
Can @VeliMattiLahtela tell us if thhis PR can be merged? |
yes, please go ahead and merge this. this can be merged. they have been tested pass locally. |
@andypowers as this appears to add automated testing for Wifi and NFC I would suggest this is worth taking into beta ? |
Summary of changes
This PR update following example test:
Impact of changes
Migration actions required
Documentation
Not required
Pull request type
Test results
Reviewers