Skip to content

LWIP: don't pbuf_free(NULL) on socket close (5.15-branch) #12869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2020
Merged

LWIP: don't pbuf_free(NULL) on socket close (5.15-branch) #12869

merged 1 commit into from
Apr 27, 2020

Conversation

kivaisan
Copy link
Contributor

Summary of changes

This is cherry-picking this fix from master to 5.15 -branch:

pbuf_free(NULL) causes an LWIP_ASSERT. Make the call conditional.

Fixes #12861

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-wan

@kjbracey
LWIP: don't pbuf_free(NULL) on socket close
9934496 
`pbuf_free(NULL)` causes an `LWIP_ASSERT`. Make the call conditional.

Fixes #12184
@kivaisan kivaisan changed the title LWIP: don't pbuf_free(NULL) on socket close LWIP: don't pbuf_free(NULL) on socket close (5.15-branch) Apr 27, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 27, 2020

@teetak01 This should fix the issue you had and reported

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 27, 2020

CI started

kjbracey
kjbracey approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@kjbracey kjbracey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is backporting #12196.

@mbed-ci
Copy link

mbed-ci commented Apr 27, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 52f1f28 into ARMmbed:mbed-os-5.15 Apr 27, 2020
@mergify mergify bot removed the ready for merge label Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@kjbracey kjbracey kjbracey approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kivaisan @0xc0170 @mbed-ci @kjbracey @AnttiKauppila