Added kv store adaptation to Nanostack file interface #12878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
requested review from
artokin,
JarkkoPaso,
juhhei01,
mikter and
a team
|
@mikaleppanen, thank you for your changes. |
mikter
reviewed
Apr 28, 2020
| }, | ||
| "use-kvstore": { | ||
| "help": "Use Mbed OS KVStore API instead of filesystem. Default: false", | ||
| "value": false |
There was a problem hiding this comment.
Would it be ok to set this true by default?
mikter
previously approved these changes
Apr 28, 2020
artokin
approved these changes
Apr 28, 2020
| void ns_file_system_api_init(void) | ||
| { | ||
| ns_file_system_set_root_path(MBED_CONF_NANOSTACK_HAL_KVSTORE_PATH); | ||
| ns_file_system_callbacks_set(ns_file_system_api_open, ns_file_system_api_close, ns_file_system_api_remove, ns_file_system_api_write, ns_file_system_api_read, ns_file_system_api_size); |
juhhei01
approved these changes
Apr 29, 2020
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
This was referenced Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Added NS filesystem API module to mbed-os Nanostack HAL. Module provides kv_store interface for the Nanostack. Feature is disabled by default on .json configuration.
Impact of changes
None
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers
@mikter @artokin @juhhei01 @JarkkoPaso