[Mbed OS 5.15] Add getsockopt option to read network property #12882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add getsockopt options NSAPI_LATENCY and NSAPI_STAGGER to read network specific timing constraints from socket. -NS_LATENCY returns estimated latency to given address. -NSAPI_STAGGER returns estimated initial delay that application should wait before transmitting data to network. Application can use the new options to avoid network congestion by adjusting transmission delays and retry timeouts. Add wrappers to make API usage easier: -get_rtt_estimate_to_address -get_stagger_estimate_to_address This is backport of the ARMmbed#12522
|
@artokin, thank you for your changes. |
0xc0170
previously approved these changes
May 7, 2020
|
CI started |
Test run: FAILEDSummary: 1 of 3 test jobs failed Failed test jobs:
|
Adjust RTT/stagger API unit tests to work in mbed-os-5.15 branch.
|
Stagger/latency unit tests fixed, would you please re-review? |
0xc0170
approved these changes
May 8, 2020
|
CI started (As we had to update the config, it might fail, will check and fix) |
|
Failure related to teh CI changes, will be fixed |
|
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
mikter
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This is backport of the PR #12522
Add getsockopt options NSAPI_LATENCY and NSAPI_STAGGER to read
network specific timing constraints from socket.
-NS_LATENCY returns estimated latency to given address.
-NSAPI_STAGGER returns estimated initial delay that application
should wait before transmitting data to network.
Application can use the new options to avoid network congestion by
adjusting transmission delays and retry timeouts.
Add wrappers to make API usage easier:
-get_rtt_estimate_to_address
-get_stagger_estimate_to_address
Impact of changes
Application is able to adapt to networks that have low bandwidth and high latency.
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-mesh , @TuomoHautamaki