Skip to content

[feature-wisun] Add getsockopt option to read network property #12883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2020

Conversation

artokin
Copy link
Contributor

@artokin artokin commented Apr 29, 2020

Summary of changes

This is backport of the PR #12522

Add getsockopt options NSAPI_LATENCY and NSAPI_STAGGER to read
network specific timing constraints from socket.
-NS_LATENCY returns estimated latency to given address.
-NSAPI_STAGGER returns estimated initial delay that application
should wait before transmitting data to network.

Application can use the new options to avoid network congestion by
adjusting transmission delays and retry timeouts.

Add wrappers to make API usage easier:
-get_rtt_estimate_to_address
-get_stagger_estimate_to_address

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-mesh , @TuomoHautamaki, @teetak01


Add getsockopt options NSAPI_LATENCY and NSAPI_STAGGER to read
network specific timing constraints from socket.
-NS_LATENCY returns estimated latency to given address.
-NSAPI_STAGGER returns estimated initial delay that application
 should wait before transmitting data to network.

Application can use the new options to avoid network congestion by
adjusting transmission delays and retry timeouts.

Add wrappers to make API usage easier:
-get_rtt_estimate_to_address
-get_stagger_estimate_to_address

This is backport of the ARMmbed#12522
mikter
mikter previously approved these changes Apr 29, 2020
@artokin artokin requested review from teetak01, TuomoHautamaki and a team April 29, 2020 11:12
teetak01
teetak01 previously approved these changes Apr 29, 2020
0xc0170
0xc0170 previously approved these changes Apr 29, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 29, 2020

I can schedule a job later today, will need to get few outstanding master jobs first now.

@mbed-ci
Copy link

mbed-ci commented May 4, 2020

Test run: FAILED

Summary: 3 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

Adjust RTT/stagger API unit tests to work in mbed-os-5.15 branch.
@mergify mergify bot dismissed stale reviews from mikter, teetak01, and 0xc0170 May 4, 2020 08:12

Pull request has been modified.

@artokin artokin requested review from 0xc0170, teetak01 and mikter May 4, 2020 11:06
@mergify mergify bot added needs: CI and removed needs: review labels May 4, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented May 5, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented May 5, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@artokin artokin merged commit 8d61f3b into ARMmbed:feature-wisun May 5, 2020
@artokin artokin deleted the feature_wisun_backport_12522 branch May 5, 2020 10:07
@mergify mergify bot removed the ready for merge label May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants