-
Notifications
You must be signed in to change notification settings - Fork 3k
Convert newlines on all terminal (tty) devices by default #12889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@hugueskamba, thank you for your changes. |
Based on the change and description, this should be |
Fine apart from description - it's not "all file descriptors". It won't be doing it to a disc file, just terminal devices (whose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hugueskamba please address Kevin's comment. Otherwise PR is fine.
CI started |
Applications can reduce their ROM usage by replacing "\r\n" by "\n".
4af80b6
to
5cb7bd5
Compare
Pull request has been modified.
CI aborted, and restarted |
This force-push amends the commit message. |
Test run: FAILEDSummary: 2 of 3 test jobs failed Failed test jobs:
|
The above is from aborted built, the new one is going fine. |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
Summary of changes
Applications can reduce their ROM usage by replacing
"\r\n" by "\n".
Impact of changes
Breaks compatibility with applications built with Mbed 2.
Migration actions required
Update to the latest version of Mbed OS (possibly using the bare metal profile for ultra-constrained devices).
Documentation
N/A
Pull request type
Test results
Reviewers
@evedon @kjbracey-arm