Skip to content

Add new configuration parameters to Wi-SUN network interface and Border Router class #12898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Add new configuration parameters to Wi-SUN network interface and Border Router class #12898

merged 2 commits into from
Jun 16, 2020

Conversation

mikaleppanen
Copy link

Summary of changes

This is port of #12657 to Mbed OS master.

Added get/validate/set functions for following Wi-SUN mesh interface configuration options:

- Network name
- Regulatory domain
- Network size
- FHSS channel mask
- FHSS unicast channel function related parameters
- FHSS broadcast channel function related parameters
- Timing parameters

Moved Wi-SUN .json configuration parsing from wisun tasklet to Wi-SUN mesh interface class.

Added Wi-SUN Border Router class. Class can be used to start and stop Wi-SUN Border Router.

Border Router class supports following configuration options:

- RPL DIO trickle parameters
- PAN configuration

Added support of network interface name method to Nanostack Mesh, EMAC and PPP interfaces.

Impact of changes

None

Migration actions required

None

Documentation

None


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mikter @artokin @juhhei01 @JarkkoPaso


mikter
mikter previously approved these changes Apr 30, 2020
@mergify mergify bot added the needs: CI label Apr 30, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 30, 2020

CI started

0xc0170
0xc0170 previously approved these changes Apr 30, 2020
@mbed-ci
Copy link

mbed-ci commented Apr 30, 2020

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_wisun-mesh-test

@mergify mergify bot added needs: work and removed needs: CI labels Apr 30, 2020
@adbridge
Copy link
Contributor

adbridge commented May 1, 2020

@mikaleppanen failures look related, please investigate asap as this needs to get into the beta release.

@mikaleppanen
Copy link
Author

Logs do not show why mesh connection setup fails:

[2020-04-30T16:53:00.555Z] 16:53:00.418 | TC MainThread: Waiting for connection 103/105
[2020-04-30T16:53:10.502Z] 16:53:10.429 | TC MainThread: Waiting for connection 104/105
[2020-04-30T16:53:20.451Z] 16:53:20.440 | TC MainThread: Waiting for connection 105/105
[2020-04-30T16:53:32.627Z] 16:53:30.451 | TC MainThread: Test Case fails because of: 2. Bootstrap failed
[2020-04-30T16:53:32.627Z] 16:53:30.451 | TC MainThread: -----------TC END-----------
[2020-04-30T16:53:32.627Z] 16:53:30.451 | TC MainThread: another fail reasons: Unknown failure reason
[2020-04-30T16:53:32.627Z] 16:53:30.451 | TC MainThread: ====tearDownTestBench====

But there is currently some instability on the mesh tests in general.

@0xc0170 0xc0170 changed the title Added new configuration parameters to Wi-SUN network interface and Border Router class Add new configuration parameters to Wi-SUN network interface and Border Router class May 4, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented May 4, 2020

I restarted the tests.

@0xc0170
Copy link
Contributor

0xc0170 commented May 4, 2020

@mikaleppanen What can we do ? It failed again after restarting

@juhhei01
Copy link
Contributor

juhhei01 commented May 4, 2020

@0xc0170 We have seen that in short time window we have some instability with Mbed-os master. Not know exactly what is issue but week ago radio driver works without problem. Is there some dramatic timer or low level init updates?

@0xc0170
Copy link
Contributor

0xc0170 commented May 4, 2020

the issue should be tracked somewhere, as it is blocking this PR..

@mikaleppanen this is not critical for beta1 ,correct?

@mikaleppanen
Copy link
Author

@0xc0170 Yes, this is not critical for beta1.

@0xc0170 0xc0170 removed the needs: CI label May 4, 2020
@mikaleppanen
Copy link
Author

@0xc0170 rebased over latest master

@mergify mergify bot dismissed stale reviews from mikter and 0xc0170 May 20, 2020 06:33

Pull request has been modified.

@mikaleppanen
Copy link
Author

@0xc0170 Can this progress?

@adbridge
Copy link
Contributor

@0xc0170 @mikter can you guys please re-review this?

@mergify mergify bot added needs: CI and removed needs: review labels Jun 11, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 15, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 15, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 2
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants