Skip to content

STM32F4 bypass PLL configuration when already done by bootloader #12924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2020
Merged

STM32F4 bypass PLL configuration when already done by bootloader #12924

merged 1 commit into from
May 6, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Fix #12922

It seems that after #12626 (and up to date drivers), system clock PLL can not be configured if PLL is already configured, which is the case with bootloader.

@ARMmbed/team-st-mcd

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant jeromecoutant mentioned this pull request May 5, 2020
Closed
@ciarmcom ciarmcom requested a review from a team May 5, 2020 17:00
@ciarmcom
Copy link
Member

ciarmcom commented May 5, 2020

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

teetak01
teetak01 approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@teetak01 teetak01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least fixes the issue for me.

@mergify mergify bot added needs: CI and removed needs: review labels May 6, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented May 6, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels May 6, 2020
@mbed-ci
Copy link

mbed-ci commented May 6, 2020

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_wisun-mesh-test

@0xc0170
Copy link
Contributor

0xc0170 commented May 6, 2020

I restarted wisun testing

@mergify mergify bot added needs: work and removed needs: CI labels May 6, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented May 6, 2020

Wisun should not be in here, I'll fix the status and will find out why it is appearing here

@0xc0170 0xc0170 merged commit c453a26 into ARMmbed:master May 6, 2020
@mergify mergify bot removed the ready for merge label May 6, 2020
@jeromecoutant jeromecoutant deleted the PR_F4_PLL branch May 6, 2020 10:22
@pilotak pilotak mentioned this pull request May 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@teetak01 teetak01 teetak01 approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mbed-cloud-client-example fatal run-time error on ST boards (SetSysClock failed)
5 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @teetak01