Correct Timeout rescheduling #12941
Merged
Correct Timeout rescheduling #12941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrono changes "optimised" `Timeout::handler` in a way that broke users who rescheduled the timeout during their attached callback. Attempted optimisation is less necessary now that `platform.callback-nontrivial` is set to false by default - that setting reduces overhead of copying the `Callback` to almost nothing.
kjbracey
force-pushed
the
chrono-timeout-fix
branch
from
a2596e8 to
0a9e1db
Compare
0xc0170
approved these changes
May 7, 2020
|
CI started |
jeromecoutant
approved these changes
May 7, 2020
Test run: FAILEDSummary: 1 of 6 test jobs failed Failed test jobs:
|
|
io serial error, restarted |
|
Thanks @kjbracey-arm ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Chrono changes "optimised"
Timeout::handlerin a way that broke users who rescheduled the timeout during their attached callback.Attempted optimisation is less necessary now that
platform.callback-nontrivialis set to false by default - that setting reduces overhead of copying theCallbackto almost nothing.Fixes #12940.
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Except that test is not currently being run in CI. I'll look at adding a similar test that is stable enough to run that would show this issue.
Reviewers
@jeromecoutant