IOTSTOR-1044 - SPIFBlockDevice is broken in Mbed OS master(6), #12981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d incorrect spi.deselect at constructor.
0xc0170
approved these changes
May 15, 2020
|
CI started |
|
@VeijoPesonen can you use this patch to verify the fix? |
|
I'm still seeing a crash on K64F: The difference is that initially the crash was in the first test, now first test fails and it crashes in the second. |
kjbracey
approved these changes
May 15, 2020
There was a problem hiding this comment.
I spotted this error during review of #12681 for two SDBlockDevice constructors, but missed it for this one :(
If you're still seeing problems I suggest going through and checking the select/deselect balance throughout the entire class - those calls went in to replace a bunch of _cs = 0 and _cs = 1, but they never needed to be balanced before.
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
AnttiKauppila
approved these changes
May 18, 2020
|
@VeijoPesonen Please verify and possibly create a new PR if anything else found |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed incorrect spi.deselect at constructor.
Summary of changes
Removed incorrect spi.deselect at constructor.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@VeijoPesonen
@AnttiKauppila
@SeppoTakalo