-
Notifications
You must be signed in to change notification settings - Fork 3k
add ESP8266 interface suspend and resume APIs #12987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@soleilplanet, thank you for your changes. |
@soleilplanet please fix the astyle errors |
* | ||
* @param direction The direction going to be suspended | ||
*/ | ||
virtual void interface_suspend(uint16_t direction); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suspend/resume wouldn't be sufficient (no need for interface_) ? I dont see it defined anywhere in Mbed OS codebase as it is here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well I put the interface_ here because I don't want to confuse the users. The API is not to suspend/resume the ESP8266 itself, but only the traffic.
But on second thought, the class itself is ESP8266Interface, so perhaps it wouldn't confuse users. How do you think?
@0xc0170 can you answer the questions please? @ARMmbed/mbed-os-ipcore could someone review this ? |
@soleilplanet , with this PR we enabled deep sleep whenever ESP gets disconnected. I think this API extension is not needed. |
Based on this, I'll close the PR. If it's not correct, please let us know or just reopen the PR with a reason. |
Summary of changes
Add and expose ESP8266 interface suspend and resume APIs to allow user applications to perform power management control with deep sleep
Impact of changes
New APIs exposed to enable/disable traffic over ESP8266 input or output interface
Migration actions required
N/A
Documentation
Need to add the API descriptions of the interface_suspend() and interface_resume()
Pull request type
Test results
Reviewers
@kjbracey-arm