LPC81X: reduce code size and add ARM_GCC support #1299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPC810 has only 4KB of flash, thus avoiding dead code is really nice. Here the NVIC interrupt setup was pulled from the us_ticker code even if no code is using timer events. This also adds ARM_GCC support for TARGET_LPC81X. LPC81X and LPC82X support Cortex M0+ VTOR register, so it is not necessary to put non-init text at 0x200.
|
FYI my mbed account (I signed cla): users/cyprien |
| else if (pin == P0_5) | ||
| enable = 1 << 6; | ||
| LPC_SWM->PINENABLE0 |= enable; | ||
| } |
There was a problem hiding this comment.
Can you please provide details for this addition?
There was a problem hiding this comment.
The LPC81X family does not have a conventional list of functions per pin, but instead each pin can received any of the "movable" functions. The only exceptions are known as "fixed-pin functions" and are nEnabled using the PINENABLE0 register (1 == disabled). On boot 3 of these fixed functions are enabled:
- SWDIO_EN is set on P0_2
- SWCLK_EN is set on P0_3
- RESET_EN is set on P0_5
If you want to use one of those pins as GPIO, you must first disable the fixed-pin function, and they'll return to their default GPIO function.
However you usually don't want to disable the RESET or the SW functions, but on a LPC810 package that has only 8 pins, this is more than appreciable.
|
Does it look ok? |
|
@0xc0170 Hi, is there anything missing? Do you want more comments in the code? |
|
LGTM |
0xc0170
added a commit
that referenced
this pull request
Sep 1, 2015
LPC81X: reduce code size and add ARM_GCC support
c1728p9
added a commit
to c1728p9/mbed-os
that referenced
this pull request
Jun 16, 2018
Fix the following warnings: -[Warning] USBTester.cpp@45,0: ARMmbed#1299-D: members and base-classes will be initialized in declaration order, not in member initialisation list order -[Warning] USBTester.h@41,0: ARMmbed#1300-D: ~USBTester inherits implicit virtual -[Warning] USBAudio.cpp@345,0: ARMmbed#1035-D: single-precision operand implicitly converted to double-precision -[Warning] USBHID.cpp@29,0: ARMmbed#1300-D: ~AsyncSend inherits implicit virtual -[Warning] USBHID.cpp@61,0: ARMmbed#1300-D: ~AsyncRead inherits implicit virtual -[Warning] USBHID.cpp@93,0: ARMmbed#1300-D: ~AsyncWait inherits implicit virtual -[Warning] EndpointResolver.cpp@125,26: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context]
c1728p9
added a commit
that referenced
this pull request
Jul 31, 2018
Fix the following warnings: -[Warning] USBTester.cpp@45,0: #1299-D: members and base-classes will be initialized in declaration order, not in member initialisation list order -[Warning] USBTester.h@41,0: #1300-D: ~USBTester inherits implicit virtual -[Warning] USBAudio.cpp@345,0: #1035-D: single-precision operand implicitly converted to double-precision -[Warning] USBHID.cpp@29,0: #1300-D: ~AsyncSend inherits implicit virtual -[Warning] USBHID.cpp@61,0: #1300-D: ~AsyncRead inherits implicit virtual -[Warning] USBHID.cpp@93,0: #1300-D: ~AsyncWait inherits implicit virtual -[Warning] EndpointResolver.cpp@125,26: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context]
c1728p9
added a commit
that referenced
this pull request
Oct 3, 2018
Fix the following warnings: -[Warning] USBTester.cpp@45,0: #1299-D: members and base-classes will be initialized in declaration order, not in member initialisation list order -[Warning] USBTester.h@41,0: #1300-D: ~USBTester inherits implicit virtual -[Warning] USBAudio.cpp@345,0: #1035-D: single-precision operand implicitly converted to double-precision -[Warning] USBHID.cpp@29,0: #1300-D: ~AsyncSend inherits implicit virtual -[Warning] USBHID.cpp@61,0: #1300-D: ~AsyncRead inherits implicit virtual -[Warning] USBHID.cpp@93,0: #1300-D: ~AsyncWait inherits implicit virtual -[Warning] EndpointResolver.cpp@125,26: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context]
c1728p9
added a commit
that referenced
this pull request
Nov 2, 2018
Fix the following warnings: -[Warning] USBTester.cpp@45,0: #1299-D: members and base-classes will be initialized in declaration order, not in member initialisation list order -[Warning] USBTester.h@41,0: #1300-D: ~USBTester inherits implicit virtual -[Warning] USBAudio.cpp@345,0: #1035-D: single-precision operand implicitly converted to double-precision -[Warning] USBHID.cpp@29,0: #1300-D: ~AsyncSend inherits implicit virtual -[Warning] USBHID.cpp@61,0: #1300-D: ~AsyncRead inherits implicit virtual -[Warning] USBHID.cpp@93,0: #1300-D: ~AsyncWait inherits implicit virtual -[Warning] EndpointResolver.cpp@125,26: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context]
juhaylinen
pushed a commit
to juhaylinen/mbed-os
that referenced
this pull request
Nov 12, 2018
Fix the following warnings: -[Warning] USBTester.cpp@45,0: ARMmbed#1299-D: members and base-classes will be initialized in declaration order, not in member initialisation list order -[Warning] USBTester.h@41,0: ARMmbed#1300-D: ~USBTester inherits implicit virtual -[Warning] USBAudio.cpp@345,0: ARMmbed#1035-D: single-precision operand implicitly converted to double-precision -[Warning] USBHID.cpp@29,0: ARMmbed#1300-D: ~AsyncSend inherits implicit virtual -[Warning] USBHID.cpp@61,0: ARMmbed#1300-D: ~AsyncRead inherits implicit virtual -[Warning] USBHID.cpp@93,0: ARMmbed#1300-D: ~AsyncWait inherits implicit virtual -[Warning] EndpointResolver.cpp@125,26: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context]
cmonr
pushed a commit
that referenced
this pull request
Nov 29, 2018
Fix the following warnings: -[Warning] USBTester.cpp@45,0: #1299-D: members and base-classes will be initialized in declaration order, not in member initialisation list order -[Warning] USBTester.h@41,0: #1300-D: ~USBTester inherits implicit virtual -[Warning] USBAudio.cpp@345,0: #1035-D: single-precision operand implicitly converted to double-precision -[Warning] USBHID.cpp@29,0: #1300-D: ~AsyncSend inherits implicit virtual -[Warning] USBHID.cpp@61,0: #1300-D: ~AsyncRead inherits implicit virtual -[Warning] USBHID.cpp@93,0: #1300-D: ~AsyncWait inherits implicit virtual -[Warning] EndpointResolver.cpp@125,26: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context]
cmonr
pushed a commit
that referenced
this pull request
Dec 4, 2018
Fix the following warnings: -[Warning] USBTester.cpp@45,0: #1299-D: members and base-classes will be initialized in declaration order, not in member initialisation list order -[Warning] USBTester.h@41,0: #1300-D: ~USBTester inherits implicit virtual -[Warning] USBAudio.cpp@345,0: #1035-D: single-precision operand implicitly converted to double-precision -[Warning] USBHID.cpp@29,0: #1300-D: ~AsyncSend inherits implicit virtual -[Warning] USBHID.cpp@61,0: #1300-D: ~AsyncRead inherits implicit virtual -[Warning] USBHID.cpp@93,0: #1300-D: ~AsyncWait inherits implicit virtual -[Warning] EndpointResolver.cpp@125,26: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context]
c1728p9
added a commit
that referenced
this pull request
Dec 19, 2018
Fix the following warnings: -[Warning] USBTester.cpp@45,0: #1299-D: members and base-classes will be initialized in declaration order, not in member initialisation list order -[Warning] USBTester.h@41,0: #1300-D: ~USBTester inherits implicit virtual -[Warning] USBAudio.cpp@345,0: #1035-D: single-precision operand implicitly converted to double-precision -[Warning] USBHID.cpp@29,0: #1300-D: ~AsyncSend inherits implicit virtual -[Warning] USBHID.cpp@61,0: #1300-D: ~AsyncRead inherits implicit virtual -[Warning] USBHID.cpp@93,0: #1300-D: ~AsyncWait inherits implicit virtual -[Warning] EndpointResolver.cpp@125,26: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context]
c1728p9
added a commit
to c1728p9/mbed-os
that referenced
this pull request
Jan 17, 2019
Fix the following warnings: -[Warning] USBTester.cpp@45,0: ARMmbed#1299-D: members and base-classes will be initialized in declaration order, not in member initialisation list order -[Warning] USBTester.h@41,0: ARMmbed#1300-D: ~USBTester inherits implicit virtual -[Warning] USBAudio.cpp@345,0: ARMmbed#1035-D: single-precision operand implicitly converted to double-precision -[Warning] USBHID.cpp@29,0: ARMmbed#1300-D: ~AsyncSend inherits implicit virtual -[Warning] USBHID.cpp@61,0: ARMmbed#1300-D: ~AsyncRead inherits implicit virtual -[Warning] USBHID.cpp@93,0: ARMmbed#1300-D: ~AsyncWait inherits implicit virtual -[Warning] EndpointResolver.cpp@125,26: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context]
c1728p9
added a commit
that referenced
this pull request
Jan 29, 2019
Fix the following warnings: -[Warning] USBTester.cpp@45,0: #1299-D: members and base-classes will be initialized in declaration order, not in member initialisation list order -[Warning] USBTester.h@41,0: #1300-D: ~USBTester inherits implicit virtual -[Warning] USBAudio.cpp@345,0: #1035-D: single-precision operand implicitly converted to double-precision -[Warning] USBHID.cpp@29,0: #1300-D: ~AsyncSend inherits implicit virtual -[Warning] USBHID.cpp@61,0: #1300-D: ~AsyncRead inherits implicit virtual -[Warning] USBHID.cpp@93,0: #1300-D: ~AsyncWait inherits implicit virtual -[Warning] EndpointResolver.cpp@125,26: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context]
c1728p9
added a commit
to c1728p9/mbed-os
that referenced
this pull request
Feb 22, 2019
Fix the following warnings: -[Warning] USBTester.cpp@45,0: ARMmbed#1299-D: members and base-classes will be initialized in declaration order, not in member initialisation list order -[Warning] USBTester.h@41,0: ARMmbed#1300-D: ~USBTester inherits implicit virtual -[Warning] USBAudio.cpp@345,0: ARMmbed#1035-D: single-precision operand implicitly converted to double-precision -[Warning] USBHID.cpp@29,0: ARMmbed#1300-D: ~AsyncSend inherits implicit virtual -[Warning] USBHID.cpp@61,0: ARMmbed#1300-D: ~AsyncRead inherits implicit virtual -[Warning] USBHID.cpp@93,0: ARMmbed#1300-D: ~AsyncWait inherits implicit virtual -[Warning] EndpointResolver.cpp@125,26: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LPC810 has only 4KB of flash, thus avoiding dead code is really nice.
Here the NVIC interrupt setup was pulled from the us_ticker code even
if no code is using timer events.
This also adds ARM_GCC support for TARGET_LPC81X.
LPC81X and LPC82X support Cortex M0+ VTOR register, so it is not
necessary to put non-init text at 0x200.