-
Notifications
You must be signed in to change notification settings - Fork 3k
tools: Warn when ARMC5 is no longer supported #13008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…olchain." For backwards compatibility reasons, as the Mbed tools must be able to build any online-compiler-supported version of Mbed, revert back to emitting a warning when ARMC5 is used. This will enable ARMC5 to continue working in the online compiler for Mbed OS 5 and other previous versions. ARMC5 remains unsupported in Mbed 6. This reverts commit 03d57b7.
Update the warning when ARMC5 is used to specify the conditions under which ARMC5 is no longer supported.
@Patater, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this goes to master, and we apply this to the online compiler - will it work for 5.15.x as well ? we dont need to propagate this patch to 5.15 branch as well?
Otherwise, this make sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok as a first step, although all this does is to change the error to a warning of course. The proof here will be whether the code actually still generates a working build for ARMC5...
CI started |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
No, this won't be needed on the 5.15 branch. The online compiler uses the tools from the latest version of Mbed. Sorry this doesn't make sense. |
Summary of changes
For backwards compatibility reasons, as the Mbed tools must be able to build any online-compiler-supported version of Mbed, revert back to emitting a warning when ARMC5 is used. This will enable ARMC5 to continue working in the online compiler for Mbed OS 5 and other previous versions. ARMC5 remains unsupported in Mbed 6.
Impact of changes
None
Migration actions required
None
Documentation
No additional documentation required.
Pull request type
Test results
Reviewers