Force callback non-trivial for IAR #13015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjbracey
reviewed
May 25, 2020
| #ifdef __ICCARM__ | ||
| /* Force callback.non-trivial for IAR */ | ||
| #undef MBED_CONF_PLATFORM_CALLBACK_NONTRIVIAL | ||
| #define MBED_CONF_PLATFORM_CALLBACK_NONTRIVIAL 1 |
There was a problem hiding this comment.
Redefining config options is icky, so I'd rather not. Can be confusing for any third parties (people or code) checking the option, potentially without looking or including here.
But I don't have a better suggestion. Don't think we can have a "toolchain override" for the JSON. I can live with this.
platform/Callback.h
Outdated
| @@ -30,6 +30,13 @@ | |||
| // MBED_CONF_PLATFORM_CALLBACK_NONTRIVIAL - support storing non-trivial function objects | |||
| // MBED_CONF_PLATFORM_CALLBACK_COMPARABLE - support memcmp comparing stored objects (requires zero padding) | |||
|
|
|||
| #ifdef __ICCARM__ | |||
| /* Force callback.non-trivial for IAR */ | |||
There was a problem hiding this comment.
platform.callback-nontrivial?
|
@jeromecoutant, thank you for your changes. |
jeromecoutant
force-pushed
the
PR_IARTRIVIAL
branch
from
1bd4e01 to
d8fc1e9
Compare
kjbracey
approved these changes
May 26, 2020
|
CI started |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
mergify
bot
added
release version missing
|
This PR does not contain release version label after merging. |
adbridge
added
release-version: 6.1.0
Release-pending
and removed
release-type: patch
0xc0170
removed
the
release version missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This fixes #12932
#12761 optimisation is disabled for IAR
Impact of changes
IAR tests are now OK
Migration actions required
Documentation
Pull request type
Test results
Reviewers