Skip to content

tests-mbed_hal-rtc patch to match IAR compilation issue #13016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Issue detected in #12932

Whole thing seems like a random compiler bug. At the specific error point you could replace 100s with seconds(100)?

@kjbracey-arm
@MarceloSalazar

Impact of changes

None for ARM and GCC

Test compilation is now OK with IAR

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@kjbracey
Copy link
Contributor

kjbracey commented May 26, 2020

"Fix" is totally random - 400s is used in the same line.

At least stick a comment next to it, otherwise someone might change it back, and there's no CI to warn them.

(And who knows when the same problem might occur elsewhere? I guess it's reassuring that it hasn't so far - there's a lot of other time_points in the real tree. Wonder what the necessary conditions are. I'd report this to IAR if I were you. Along with the nontrivial lambda thing - which isn't technically a bug, but is distinctly suboptimal for embedded optimisation.)

@ciarmcom ciarmcom requested review from a team May 26, 2020 09:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-hal @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 2, 2020

Travis restarted, this will go into CI

@0xc0170 0xc0170 removed the request for review from a team June 2, 2020 09:00
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 5, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 5, 2020

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jun 5, 2020
@0xc0170 0xc0170 merged commit 867cd0f into ARMmbed:master Jun 5, 2020
@mergify mergify bot added release version missing When PR does not contain release version, bot should label it and we fix it afterwards and removed ready for merge labels Jun 5, 2020
@mergify
Copy link

mergify bot commented Jun 5, 2020

This PR does not contain release version label after merging.

@jeromecoutant jeromecoutant deleted the PR_RTCTEST branch June 5, 2020 14:43
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
@0xc0170 0xc0170 removed the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants