Skip to content

BLE: remove limitation in the Cordio to update adv payload #13039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

pan-
Copy link
Member

@pan- pan- commented May 29, 2020

Summary of changes

Nothing in the Bluetooth standard prevents update of advertising payload while advertising is active.
This limitation wasn't present in previous version of the stack and is not present for extended advertising. It is removed from legacy advertising with this patch.

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Reviewers

@paul-szczepanek-arm


Nothing in the Bluetooth standard prevents update of advertising payload while advertising is active.
This limitation wasn't present in previous version of the stack and is not present for extended advertising.
@ciarmcom
Copy link
Member

@pan-, thank you for your changes.
@paul-szczepanek-arm @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from paul-szczepanek-arm and a team May 29, 2020 17:00
@mergify mergify bot added needs: CI and removed needs: review labels Jun 9, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 10, 2020

All green but the incorrect status reported from mergify makes it red. I'll merge as it can't be overwritten.

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jun 10, 2020
@0xc0170 0xc0170 merged commit f858000 into ARMmbed:master Jun 10, 2020
@mergify mergify bot removed the ready for merge label Jun 10, 2020
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants