Skip to content

CYESKIT_064B0S2_4343W: Remove parentheses from arduino pins #13045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2020
Merged

CYESKIT_064B0S2_4343W: Remove parentheses from arduino pins #13045

merged 1 commit into from
Jun 5, 2020

Conversation

kyle-cypress
Copy link

@kyle-cypress kyle-cypress commented May 30, 2020 •
edited
Loading

Summary of changes

Avoid build failures when arduino pin names collide with C++ template
argument names.
Addresses #13027

Impact of changes

NA

Migration actions required

NA

Documentation

NA

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/team-cypress

CYESKIT_064B0S2_4343W: Remove parentheses from arduino pins
7ad94db 
Avoid build failures when arduino pin names collide with C++ template
argument names.
Addresses issue ARMmbed#13027
@kyle-cypress
Copy link
Author

Note: this is a targetted fix to address the immediate breakage noted in #13027. We are discussing whether similar updates should be applied to our other targets and will address those via a separate PR if necessary.

@ciarmcom ciarmcom requested review from maclobdell and a team May 30, 2020 01:00
@ciarmcom
Copy link
Member

@kyle-cypress, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

maclobdell
maclobdell approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@maclobdell maclobdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this change independently and it works for me.

@mergify mergify bot added needs: CI and removed needs: review labels Jun 1, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 5, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 5, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jun 5, 2020
@0xc0170 0xc0170 merged commit 95a704e into ARMmbed:master Jun 5, 2020
@mergify mergify bot added release version missing When PR does not contain release version, bot should label it and we fix it afterwards and removed ready for merge labels Jun 5, 2020
@mergify
Copy link

mergify bot commented Jun 5, 2020

This PR does not contain release version label after merging.

@maclobdell maclobdell mentioned this pull request Jun 9, 2020
Closed
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
@0xc0170 0xc0170 removed the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@maclobdell maclobdell maclobdell approved these changes

Assignees
No one assigned
Labels
devices: cypress release-version: 6.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kyle-cypress @ciarmcom @0xc0170 @mbed-ci @maclobdell @adbridge