Skip to content

[feature-wisun] targets:lpspi and uart_3: Update the lpspi driver and add uart_3 support #13063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2020

Conversation

liugang-gavin
Copy link
Contributor

Change the lpspi default transfer delays to fix the data corruption
issue.

Add the loop and judgement to retry transfer when spi bus is busy.

Add the judgement statement to fix the hang issue.

Signed-off-by: TimWang [email protected]

Summary of changes

Impact of changes

Migration actions required

Documentation


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested a review from a team June 4, 2020 03:00
@ciarmcom
Copy link
Member

ciarmcom commented Jun 4, 2020

@liugang-gavin, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Jun 4, 2020
@mergify mergify bot added needs: CI and removed needs: review labels Jun 4, 2020
@mergify mergify bot dismissed 0xc0170’s stale review June 9, 2020 06:21

Pull request has been modified.

Change the lpspi default transfer delays to fix the data corruption
issue.

Add the loop and judgement to retry transfer when spi bus is busy.

Add the judgement statement to fix the hang issue.

Signed-off-by: TimWang <[email protected]>
Add uart_3 support, which using GPIO_AD_B1_06 as TX pin, GPIO_AD_B1_07
as RX pin

Signed-off-by: timwang <[email protected]>
@liugang-gavin liugang-gavin changed the title targets:lpspi: Update the lpspi driver and api targets:lpspi and uart_3: Update the lpspi driver and add uart_3 support Jun 9, 2020
@artokin artokin requested review from JarkkoPaso and a team June 9, 2020 07:50
@artokin artokin changed the title targets:lpspi and uart_3: Update the lpspi driver and add uart_3 support [feature-wisun] targets:lpspi and uart_3: Update the lpspi driver and add uart_3 support Jun 9, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants