Skip to content

mergify: add release type #13066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2020
Merged

mergify: add release type #13066

merged 2 commits into from
Jun 9, 2020

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Jun 4, 2020

Summary of changes

Fixing new release-type label for mergify.

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170 0xc0170 requested a review from adbridge June 4, 2020 13:01
@0xc0170
mergify: add release type 2.2
a4a07ea 
Also handle label removal for this new type
@0xc0170 0xc0170 force-pushed the fix_release_type branch from c26ba21 to a4a07ea Compare June 4, 2020 13:24
@0xc0170
Copy link
Contributor Author

0xc0170 commented Jun 4, 2020

Lets try to build. I merged couple of PRs

@ciarmcom ciarmcom requested a review from a team June 4, 2020 15:00
@ciarmcom
Copy link
Member

ciarmcom commented Jun 4, 2020

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jun 8, 2020

I restarted travis, did not report status back

adbridge
adbridge approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170 0xc0170 added needs: CI ready for merge release-type: patch Indentifies a PR as containing just a patch and removed needs: review needs: CI labels Jun 8, 2020
@0xc0170 0xc0170 merged commit 998d06a into ARMmbed:master Jun 9, 2020
@0xc0170 0xc0170 deleted the fix_release_type branch June 9, 2020 07:18
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adbridge adbridge adbridge approved these changes

Assignees
No one assigned
Labels
release-version: 6.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xc0170 @ciarmcom @adbridge