Skip to content

Remove Musca A1 target #13165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2020
Merged

Remove Musca A1 target #13165

merged 1 commit into from
Jun 22, 2020

Conversation

MarceloSalazar
Copy link

Summary of changes

The Musca A1 target hasn't been Mbed Enabled nor considered supported in 6.0.
Although exist in Mbed OS 5.15 and 6.0, it is not officially supported and hence removed from master as left my mistake.
However, it continues to be available in 5.15.

Impact of changes

NA - continues to be available in the mbed-os-5.15 branch.

Migration actions required

Switch to the mbed-os-5.15 branch.

Documentation

NA

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/team-arm-oss-platform

@MarceloSalazar MarceloSalazar mentioned this pull request Jun 22, 2020
Closed
@ciarmcom
Copy link
Member

@MarceloSalazar, thank you for your changes.
@ashok-rao @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from ashok-rao and a team June 22, 2020 09:00
0xc0170
0xc0170 previously approved these changes Jun 22, 2020
View reviewed changes
@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jun 22, 2020
@mergify mergify bot added needs: CI and removed needs: review labels Jun 22, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 22, 2020

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 22, 2020

@MarceloSalazar Can you update the commit msg to provide a reason for removing this target (can be taken from description in this PR)? I'll start new test (will abort this one)

Remove Musca A1 target
dbbdb3f 
The MUSCA_A1 target isn't supported in Mbed OS 6.
Removing as it was left in master by mistake.
However, it continues to be available in 5.15 branch.
@mergify mergify bot dismissed 0xc0170’s stale review June 22, 2020 12:28

Pull request has been modified.

@MarceloSalazar
Copy link
Author

@0xc0170 commit message updated as requested. Please start CI when you have chance.
I'll follow up over email with internal approvals. Thanks.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 22, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 22, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit b4389c7 into ARMmbed:master Jun 22, 2020
@mergify mergify bot removed the ready for merge label Jun 22, 2020
@MarceloSalazar MarceloSalazar mentioned this pull request Jun 22, 2020
Closed
@jainvikas8 jainvikas8 mentioned this pull request Jun 26, 2020
Closed
@adbridge adbridge removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 30, 2020
jainvikas8 added a commit to jainvikas8/mbed-os that referenced this pull request Jan 18, 2021
@jainvikas8
Remove: ARM_MUSCA_A1 support
dff3b08 
ARM_MUSCA_A1 is not supported since Mbed Os 6.0
ARMmbed#13165

Therefore remove files.
jainvikas8 added a commit to jainvikas8/mbed-os that referenced this pull request Jan 19, 2021
@jainvikas8
Remove: ARM_MUSCA_A1 support
af9962d 
ARM_MUSCA_A1 is not supported since Mbed Os 6.0
ARMmbed#13165

Therefore remove files.
jainvikas8 added a commit to jainvikas8/mbed-os that referenced this pull request Jan 19, 2021
@jainvikas8
Remove: ARM_MUSCA_A1 support
1cd45a8 
ARM_MUSCA_A1 is not supported since Mbed Os 6.0
ARMmbed#13165

Therefore remove files.
jainvikas8 added a commit to jainvikas8/mbed-os that referenced this pull request Jan 19, 2021
@jainvikas8
Remove: ARM_MUSCA_A1 support
8d7a666 
ARM_MUSCA_A1 is not supported since Mbed Os 6.0
ARMmbed#13165

Therefore remove files.
jainvikas8 added a commit to jainvikas8/mbed-os that referenced this pull request Jan 19, 2021
@jainvikas8
Remove: ARM_MUSCA_A1 support
ffff332 
ARM_MUSCA_A1 is not supported since Mbed Os 6.0
ARMmbed#13165

Therefore remove files.
jainvikas8 added a commit to jainvikas8/mbed-os that referenced this pull request Jan 20, 2021
@jainvikas8
Remove: ARM_MUSCA_A1 support
f859ee2 
ARM_MUSCA_A1 is not supported since Mbed Os 6.0
ARMmbed#13165

Therefore remove files.
jainvikas8 added a commit to jainvikas8/mbed-os that referenced this pull request Jan 20, 2021
@jainvikas8
Remove: ARM_MUSCA_A1 support
6753ce8 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: ARMmbed#13165

Therefore remove files from kv_config and TF-M post binary hook script.
jainvikas8 added a commit to jainvikas8/mbed-os that referenced this pull request Jan 20, 2021
@jainvikas8
Remove: ARM_MUSCA_A1 support
6379f0b 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: ARMmbed#13165

Therefore remove files from kv_config and TF-M post binary hook script.
LDong-Arm pushed a commit to LDong-Arm/mbed-os that referenced this pull request Jan 21, 2021
@jainvikas8 @LDong-Arm
Remove: ARM_MUSCA_A1 support
b9c6304 
ARM_MUSCA_A1 is not supported since Mbed Os 6.0
ARMmbed#13165

Therefore remove files.
jainvikas8 added a commit to jainvikas8/mbed-os that referenced this pull request Jan 22, 2021
@jainvikas8
Remove: ARM_MUSCA_A1 support
90578e0 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: ARMmbed#13165

Therefore remove files from kv_config and TF-M post binary hook script.
LDong-Arm pushed a commit to LDong-Arm/mbed-os that referenced this pull request Jan 25, 2021
@jainvikas8 @LDong-Arm
Remove: ARM_MUSCA_A1 support
69c7c1e 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: ARMmbed#13165

Therefore remove files from kv_config and TF-M post binary hook script.
jainvikas8 added a commit to jainvikas8/mbed-os that referenced this pull request Jan 26, 2021
@jainvikas8
Remove: ARM_MUSCA_A1 support
e1949d1 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: ARMmbed#13165

Therefore remove files from kv_config and TF-M post binary hook script.
jainvikas8 added a commit to jainvikas8/mbed-os that referenced this pull request Jan 26, 2021
@jainvikas8
Remove: ARM_MUSCA_A1 support
1766d55 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: ARMmbed#13165

Therefore remove files from kv_config and TF-M post binary hook script.
jainvikas8 added a commit to jainvikas8/mbed-os that referenced this pull request Jan 27, 2021
@jainvikas8
Remove: ARM_MUSCA_A1 support
c0c70f4 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: ARMmbed#13165

Therefore remove files from kv_config and TF-M post binary hook script.
jainvikas8 added a commit to jainvikas8/mbed-os that referenced this pull request Jan 27, 2021
@jainvikas8
Remove: ARM_MUSCA_A1 support
eed296b 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: ARMmbed#13165

Therefore remove files from kv_config and TF-M post binary hook script.
jainvikas8 added a commit to jainvikas8/mbed-os that referenced this pull request Jan 27, 2021
@jainvikas8
Remove: ARM_MUSCA_A1 support
df66e25 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: ARMmbed#13165

Therefore remove files from kv_config and TF-M post binary hook script.
evedon pushed a commit that referenced this pull request Jan 28, 2021
@jainvikas8 @evedon
Remove: ARM_MUSCA_A1 support
0fce31d 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: #13165

Therefore remove files from kv_config and TF-M post binary hook script.
LDong-Arm pushed a commit to LDong-Arm/mbed-os that referenced this pull request Jan 28, 2021
@jainvikas8 @LDong-Arm
Remove: ARM_MUSCA_A1 support
8523687 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: ARMmbed#13165

Therefore remove files from kv_config and TF-M post binary hook script.
LDong-Arm pushed a commit to LDong-Arm/mbed-os that referenced this pull request Feb 1, 2021
@jainvikas8 @LDong-Arm
Remove: ARM_MUSCA_A1 support
6a30108 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: ARMmbed#13165

Therefore remove files from kv_config and TF-M post binary hook script.
LDong-Arm pushed a commit to LDong-Arm/mbed-os that referenced this pull request Feb 9, 2021
@jainvikas8 @LDong-Arm
Remove: ARM_MUSCA_A1 support
fd0d5c6 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: ARMmbed#13165

Therefore remove files from kv_config and TF-M post binary hook script.
LDong-Arm pushed a commit to LDong-Arm/mbed-os that referenced this pull request Feb 16, 2021
@jainvikas8 @LDong-Arm
Remove: ARM_MUSCA_A1 support
5ba6542 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: ARMmbed#13165

Therefore remove files from kv_config and TF-M post binary hook script.
LDong-Arm pushed a commit to LDong-Arm/mbed-os that referenced this pull request Feb 16, 2021
@jainvikas8 @LDong-Arm
Remove: ARM_MUSCA_A1 support
2c66939 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: ARMmbed#13165

Therefore remove files from kv_config and TF-M post binary hook script.
LDong-Arm pushed a commit to LDong-Arm/mbed-os that referenced this pull request Feb 23, 2021
@jainvikas8 @LDong-Arm
Remove: ARM_MUSCA_A1 support
1932763 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: ARMmbed#13165

Therefore remove files from kv_config and TF-M post binary hook script.
LDong-Arm pushed a commit to LDong-Arm/mbed-os that referenced this pull request Feb 23, 2021
@jainvikas8 @LDong-Arm
Remove: ARM_MUSCA_A1 support
371409f 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: ARMmbed#13165

Therefore remove files from kv_config and TF-M post binary hook script.
LDong-Arm pushed a commit to LDong-Arm/mbed-os that referenced this pull request Feb 23, 2021
@jainvikas8 @LDong-Arm
Remove: ARM_MUSCA_A1 support
88c724d 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: ARMmbed#13165

Therefore remove files from kv_config and TF-M post binary hook script.
LDong-Arm pushed a commit to LDong-Arm/mbed-os that referenced this pull request Feb 25, 2021
@jainvikas8 @LDong-Arm
Remove: ARM_MUSCA_A1 support
8648e4f 
ARM_MUSCA_A1 is not supported since Mbed OS 6.0
Refer: ARMmbed#13165

Therefore remove files from kv_config and TF-M post binary hook script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@ashok-rao ashok-rao Awaiting requested review from ashok-rao

Assignees
No one assigned
Labels
priority: high release-version: 6.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MarceloSalazar @ciarmcom @0xc0170 @mbed-ci @adbridge